-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM Metadata API: Adds an option to disable VM metadata API call #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
July 3, 2024 02:16
sourabh1007
changed the title
VM Metadata Api: Adds an option to disable VM metadata API call
VM Metadata API: Adds an option to disable VM metadata API call
Jul 3, 2024
sourabh1007
force-pushed
the
users/sourabhjain/skipvmcall
branch
from
July 3, 2024 02:29
908cb02
to
c8b00b4
Compare
sourabh1007
force-pushed
the
users/sourabhjain/skipvmcall
branch
from
July 3, 2024 02:30
c8b00b4
to
db04319
Compare
FabianMeiswinkel
previously approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except one nit.
ealsur
reviewed
Jul 3, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/VmMetadataApiHandlerTest.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jul 3, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/VmMetadataApiHandlerTest.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jul 3, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/VmMetadataApiHandlerTest.cs
Outdated
Show resolved
Hide resolved
ealsur
previously approved these changes
Jul 3, 2024
FabianMeiswinkel
previously approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kirankumarkolli
previously approved these changes
Jul 5, 2024
sourabh1007
dismissed stale reviews from kirankumarkolli and FabianMeiswinkel
via
July 8, 2024 00:32
2a22d04
sourabh1007
force-pushed
the
users/sourabhjain/skipvmcall
branch
from
July 8, 2024 00:39
4c6f2d5
to
c2b81fb
Compare
Please refresh the description with new ENV naming. |
kirankumarkolli
approved these changes
Jul 8, 2024
ealsur
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of this PR, adding capability to stop instance metadata API call
and 2 minor variable name change (spelling correction)
Type of change
Closing issues
To automatically close an issue: closes #4187