Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM Metadata API: Adds an option to disable VM metadata API call #4568

Merged
merged 9 commits into from
Jul 8, 2024

Conversation

sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Jul 3, 2024

Description

As part of this PR, adding capability to stop instance metadata API call

  1. Introduce COSMOS_DISABLE_IMDS_ACCESS env variable, to stop calling Instance Metadata API call, if set as true.

and 2 minor variable name change (spelling correction)

Type of change

  • [] New feature (non-breaking change which adds functionality)

Closing issues

To automatically close an issue: closes #4187

@sourabh1007 sourabh1007 changed the title VM Metadata Api: Adds an option to disable VM metadata API call VM Metadata API: Adds an option to disable VM metadata API call Jul 3, 2024
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/skipvmcall branch from 908cb02 to c8b00b4 Compare July 3, 2024 02:29
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/skipvmcall branch from c8b00b4 to db04319 Compare July 3, 2024 02:30
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one nit.

ealsur
ealsur previously approved these changes Jul 3, 2024
@sourabh1007 sourabh1007 self-assigned this Jul 4, 2024
@sourabh1007 sourabh1007 added the auto-merge Enables automation to merge PRs label Jul 4, 2024
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kirankumarkolli
kirankumarkolli previously approved these changes Jul 5, 2024
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/skipvmcall branch from 4c6f2d5 to c2b81fb Compare July 8, 2024 00:39
@kirankumarkolli
Copy link
Member

Please refresh the description with new ENV naming.

@ealsur ealsur merged commit 6d36c36 into master Jul 8, 2024
22 checks passed
@ealsur ealsur deleted the users/sourabhjain/skipvmcall branch July 8, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Skip VmMetadataApiHandler when running outside a VM
4 participants