-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFP AVAD: Adds new FeedRange to ChangeFeedProcessorContext #4621
CFP AVAD: Adds new FeedRange to ChangeFeedProcessorContext #4621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Blocking myself. Some other tests are failing and I need to run UpdateContracts.ps1 |
Fixed |
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/FeedProcessing/ProcessorOptions.cs
Outdated
Show resolved
Hide resolved
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some small polishing comments
…ProcessorOptions.cs Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorContext.cs
Show resolved
Hide resolved
…ublic-access-to-feedrange-from-changefeedprocessorcontext
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorContext.cs
Outdated
Show resolved
Hide resolved
…ssorContext.cs Co-authored-by: Ruben Bartelink <ruben@bartelink.com>
…ge-from-changefeedprocessorcontext
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ChangeFeed/DynamicTests.cs
Outdated
Show resolved
Hide resolved
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
…ublic-access-to-feedrange-from-changefeedprocessorcontext
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ChangeFeed/DynamicTests.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ChangeFeed/DynamicTests.cs
Outdated
Show resolved
Hide resolved
…ge-from-changefeedprocessorcontext
…ge-from-changefeedprocessorcontext
ee33928
into
master
Pull Request Template
Details on #4620
Description
Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4620