Implementing HTTP request data representation #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettsam
reviewed
Feb 12, 2021
|
|
||
| namespace Microsoft.Azure.Functions.Worker | ||
| { | ||
| public enum SameSite |
There was a problem hiding this comment.
Do we need to replicate every type like this? For example, we use System.Net.HttpStatusCode in responses.
mhoeger
reviewed
Feb 13, 2021
fabiocav
force-pushed
the
fabiocav/httprequestdata
branch
2 times, most recently
from
c37b6f3
to
ae57b28
Compare
SeanFeldman
reviewed
Feb 14, 2021
brettsam
reviewed
Feb 16, 2021
brettsam
approved these changes
Feb 16, 2021
fabiocav
force-pushed
the
fabiocav/httprequestdata
branch
from
263bd73
to
b7089a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation, some cleanup still in progress.
Resolves #110
Resolves #112
Resolves #121
Related to #122
Updates to the response will come in a separate PR.