removing System.Text.Json dependency and instead using Azure.Core.Serialization.ObjectSerializer #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettsam
force-pushed
the
brettsam/json
branch
from
65b3d39
to
345e0da
Compare
fabiocav
reviewed
Feb 18, 2021
brettsam
force-pushed
the
brettsam/json
branch
from
345e0da
to
fb0bb8c
Compare
fabiocav
approved these changes
Feb 18, 2021
| public ObjectSerializer Serializer | ||
| { | ||
| get => _serializer ??= new JsonObjectSerializer(); | ||
| set => _serializer = value; |
There was a problem hiding this comment.
Should we perform a null check on the value? Do we ever want to allow this to be set to null?
brettsam
force-pushed
the
brettsam/json
branch
from
fb0bb8c
to
dd52cf6
Compare
brettsam
force-pushed
the
brettsam/json
branch
from
dd52cf6
to
d42fc1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83