Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceBusSessionMessageActions management APIs: worker changes #2404

Merged
merged 12 commits into from
Jun 4, 2024
Merged

ServiceBusSessionMessageActions management APIs: worker changes #2404

merged 12 commits into from
Jun 4, 2024

Conversation

aishwaryabh
Copy link
Contributor

@aishwaryabh aishwaryabh commented Apr 17, 2024 •
edited
Loading

Issue describing the changes in this PR

resolves #2374

This PR adds support ServiceBusSessionMessageActions. The corresponding changes in the WebJobs extension have already been deployed in the latest package. This PR consumes those changes by updating the proto and creating the appropriate converters.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@aishwaryabh
Copy link
Contributor Author

Going to work on this soon

@aishwaryabh aishwaryabh reopened this May 16, 2024
@H-Finch-404
Copy link

Any ETA on when this will be ready & released? Nice to see this being finally worked on!

@aishwaryabh aishwaryabh marked this pull request as ready for review May 30, 2024 21:25
fabiocav
fabiocav reviewed May 31, 2024
View reviewed changes
extensions/Worker.Extensions.ServiceBus/src/ServiceBusSessionMessageActions.cs Show resolved Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusSessionMessageActions.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusSessionMessageActions.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusSessionMessageActions.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusSessionMessageActions.cs Show resolved Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusMessageActions.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusSessionMessageActionsConverter.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusSessionMessageActionsConverter.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusSessionMessageActionsConverter.cs Show resolved Hide resolved
samples/Extensions/Extensions.csproj Outdated Show resolved Hide resolved
@aishwaryabh aishwaryabh mentioned this pull request Jun 3, 2024
Open
fabiocav
fabiocav approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a small comment about the exception message.

extensions/Worker.Extensions.ServiceBus/src/ServiceBusSessionMessageActionsConverter.cs Outdated Show resolved Hide resolved
@aishwaryabh aishwaryabh merged commit be0b8b3 into main Jun 4, 2024
21 checks passed
@aishwaryabh aishwaryabh deleted the aibhandari/service-bus-session-action branch June 4, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliankasem liliankasem liliankasem left review comments

@jviau jviau jviau approved these changes

@fabiocav fabiocav fabiocav approved these changes

Assignees
No one assigned
Labels
Needs: Attention 👋
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ServiceBusSessionMessageActions] Implement session management APIs
5 participants
@aishwaryabh @H-Finch-404 @liliankasem @fabiocav @jviau