Support SignalR trigger return value #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satvu
approved these changes
Oct 11, 2024
|
@Y-Sindo Can you merge main to your branch to make sure you have this change included which will allow the pipeline to run? Thanks! |
|
The fixes have been applied to .NET6 package: Microsoft.Azure.WebJobs.Extensions.SignalRService whereas the same issue exists in .NET8 version of this package: Microsoft.Azure.Functions.Worker.Extensions.SignalRService. Please kindly confirm when will the fix be propagated to this library for .NET8 applications |
|
@waqarzafar The fix is already released. Please update your SignalR worker extensions to 1.15.0. Thanks! Please note that if you need to use managed identity to connect to Azure SignalR service, 1.15.0 is not working until a common issue Azure/azure-functions-host#10575 is fixed. |
jviau
added a commit
that referenced
this pull request
Oct 23, 2024
* Generators package version update (#2755) * Generator tests: Add transitive dependency for System.Text.Json v8.0.5 & bump extension versions (#2760) * Fixing Function Executor test * Refactor WebJobs extension info (#2762) * skipBuildTagsForGitHubPullRequests when the PR is a fork (#2770) * Bump System.Text.Json from 8.0.4 to 8.0.5 in /host/src/FunctionsNetHost (#2768) Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.4 to 8.0.5. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v8.0.4...v8.0.5) --- updated-dependencies: - dependency-name: System.Text.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * re-use FunctionsWorkerApplicationBuilder if called multiple times (#2774) * Add worker extension validation to CI (#2764) * ignore rider temp files * Support SignalR trigger return value (#2771) * add skipBuildTagsForGitHubPullRequests for extensions (#2779) * Fix typos in CI referencing test projects (#2773) * Adding a null check before initiating the internal Activity (#2765) * Adding a null check for the internal Activity. * Bump System.Text.Json to 8.0.5 (#2783) * Use full namespace for Task.FromResult in function metadata provider generator to avoid namespace conflict (#2681) * Analyzer for Multiple-Output Binding Scenarios with ASP.NET Core Integration (#2706) * Remove documentation tag (#2751) The parameter does not exist. * Update global.json .net8 value (#2795) * initial fix of duplicate registrations if AddFunctionsWorkerCore called twice (#2790) * Ignoring fatal exceptions in InvocationHandler (#2789) * Update nethost global json, update sample (#2797) * Set extension RPC max message length (#2772) * Set max message length for RPC client * Update Rpc version and release notes * Update packages (#2800) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Surbhi Gupta <surgupta@microsoft.com> Co-authored-by: Lilian Kasem <likasem@microsoft.com> Co-authored-by: Fabio Cavalcante <facaval@microsoft.com> Co-authored-by: sarah <35204912+satvu@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brett Samblanet <brettsam@microsoft.com> Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: yzt <zityang@microsoft.com> Co-authored-by: Rohit Ranjan <90008725+RohitRanjanMS@users.noreply.github.com> Co-authored-by: David Lee <10739819+DL444@users.noreply.github.com> Co-authored-by: Jonathan <vanillajonathan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the return value of SignalR trigger not working issue
resolves #1496
Pull request checklist
release_notes.md