Skip to content

Commit

Permalink
4.28.4 (#9781)
Browse files Browse the repository at this point in the history
* Fixing header lookup for perf/consistency (#9776)
---------

Co-authored-by: Fabio Cavalcante <facaval@microsoft.com>
Co-authored-by: azfuncgh <azfuncgh@github.com>
  • Loading branch information
3 people authored Jan 9, 2024
1 parent 359eb50 commit 4736a79
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion build/common.props
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<LangVersion>latest</LangVersion>
<MajorVersion>4</MajorVersion>
<MinorVersion>28</MinorVersion>
<PatchVersion>3</PatchVersion>
<PatchVersion>4</PatchVersion>
<BuildNumber Condition="'$(BuildNumber)' == '' ">0</BuildNumber>
<PreviewVersion></PreviewVersion>

Expand Down
3 changes: 1 addition & 2 deletions release_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@

<!-- Please add your release notes in the following format:
- My change description (#PR)
-->
- Update Python Worker Version to [4.23.0](https://github.com/Azure/azure-functions-python-worker/releases/tag/4.23.0)
-->
5 changes: 2 additions & 3 deletions src/WebJobs.Script/Extensions/HttpRequestExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
using Microsoft.AspNetCore.Http.Extensions;
using Microsoft.AspNetCore.WebUtilities;
using Microsoft.Azure.WebJobs.Extensions.Http;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Primitives;
using Newtonsoft.Json;
Expand Down Expand Up @@ -85,9 +84,9 @@ public static bool IsAppServiceInternalRequest(this HttpRequest request, IEnviro
}

// this header will *always* be present on requests originating externally (i.e. going
// through the Anatares front end). For requests originating internally it will NOT be
// through the Antares front end). For requests originating internally it will NOT be
// present.
return !request.Headers.Keys.Contains(ScriptConstants.AntaresLogIdHeaderName);
return !request.Headers.ContainsKey(ScriptConstants.AntaresLogIdHeaderName);
}

public static bool IsPlatformInternalRequest(this HttpRequest request, IEnvironment environment = null)
Expand Down

0 comments on commit 4736a79

Please sign in to comment.