Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder arguments resolving logics to full support middleware - V5 - breaking change. #648

Open
kaibocai opened this issue Sep 15, 2022 · 0 comments

Comments

@kaibocai
Copy link
Member

kaibocai commented Sep 15, 2022

For today's middleware support logics we are convert the parameter payload to String for middleware to consume during the invocation request at

,

This has limitation as middleware is getting the payload that already got transferred to String type. Middleware may want to use the original type of parameter payload which build by java worker. I see from two advantages of this approach:

  • Give more fliexibility to middleware when they want to play around the input parameter payload, not only restrict payload type to String.
  • Reduce the repeat work we already did in the worker - convert the payload type from GRPC type to corresponding java type. Currently without this we are trying to did the same worker for middleware only different we convert all GRPC type to String.

Attached the potential PR here https://github.com/Azure/azure-functions-java-worker/tree/kaibocai/v5-bench

Potential break changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant