Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request.headers.get() returns string with commas instead of semicolons as delimiter on Windows #234

Open
ibenrh opened this issue Feb 20, 2024 · 1 comment
Labels
bug Something isn't working P3

Comments

@ibenrh
Copy link

ibenrh commented Feb 20, 2024

When using request.headers.get("cookie") on https I get a string that uses commas instead of semicolons as delimiters, even though the cookie in the Header in browser clearly has semicolons as delimiters.

Example: https://github.com/pellebjerkestrand/azure-functions-core-tools-https-cookie-commas

The expected behavior is for the delimiter to be the same as in the browser.

@ejizba ejizba transferred this issue from Azure/azure-functions-core-tools Mar 13, 2024
@ejizba
Copy link
Contributor

ejizba commented Mar 19, 2024

I can repro this on windows with --useHttps. Interestingly, the problem seems to go away if you use the preview http streaming feature.

app.setup({ enableHttpStream: true });

I'm pretty sure our node.js logic is just passing along the headers we get from the host, so this one might have to be addressed in the host

Possibly related to Azure/azure-functions-host#4486 and/or dotnet/runtime#42856. Note it's confusing because "Set-Cookie" is supposed to use a comma as a delimiter but "Cookie" is supposed to use a semicolon.

@ejizba ejizba added bug Something isn't working P3 labels Mar 19, 2024
@ejizba ejizba added this to the Backlog Candidates milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3
Projects
None yet
Development

No branches or pull requests

2 participants