Upgrade 'typescript' to v5 #303
Conversation
| @@ -53,15 +53,15 @@ | |||
| "@types/long": "^4.0.2", | |||
| "@types/minimist": "^1.2.2", | |||
| "@types/mocha": "^9.1.1", | |||
| "@types/node": "^18.0.0", | |||
| "@types/node": "^22.7.5", | |||
There was a problem hiding this comment.
You can bump this to a higher minor or patch version of 18.x, but we need the major version to stay 18 as that is our minimum supported node.js version
| @@ -78,8 +78,8 @@ | |||
| "semver": "^7.3.5", | |||
| "ts-loader": "^9.3.1", | |||
| "ts-node": "^3.3.0", | |||
| "typescript": "^4.5.5", | |||
| "typescript4": "npm:typescript@~4.0.0", | |||
| "typescript": "^5.0.0", | |||
There was a problem hiding this comment.
Hi @fseitun, we can't bump TypeScript across major versions without doing a new major version ourselves, which we're not ready to do at this time. The only way we would support TypeScript 5 is if we can support both 4 and 5 at the same time, which I honestly just haven't tested yet.
Here's how you would do it:
- Instead of replacing
typescript4in this file, add another line fortypescript5 - In the test file, add '5' to the array instead of replacing '4'
Then it's a matter of figuring out how to get the test for both 4 and 5 passing at the same time, which I anticipate is the actually interesting part of this.
|
Thanks for the feedback! I'm pausing this momentarily, I will try to come back as soon as I find time. |
microsoft-github-policy-service
bot
added
Needs: Attention 👋
and removed
Needs: Author Feedback
labels
Closes #269
Upgrades typescript to V5