Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js v12 support for azure-iot-security-tpm #930

Closed
steinera opened this issue Feb 9, 2021 · 5 comments
Closed

Node.js v12 support for azure-iot-security-tpm #930

steinera opened this issue Feb 9, 2021 · 5 comments
Assignees
Labels
build issue IoTSDK tracks all IoT SDK issues across the board

Comments

@steinera
Copy link

steinera commented Feb 9, 2021

At the moment it is not possible to use azure-iot-security-tpm with Node.js version 12 or higher. This is because the dependency build of the used ref-package fails.

C:\<repo>\node_modules\ref>if not defined npm_config_node_gyp (node "C:\Users\<user>\AppData\Roaming\nvm\v12.16.1\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "C:\Users\<user>\AppData\Roaming\nvm\v12.16.1\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  binding.cc
  win_delay_load_hook.cc
..\src\binding.cc(222): error C2661: 'v8::Value::BooleanValue': no overloaded function takes 0 arguments [C:\<repo>\node_modules\ref\build\binding.vc
xproj]
...
@steinera
Copy link
Author

We like to continue our work with azure-iot-security-tpm, but at the moment we are unsure if it would make sense to wait for a fix. Does someone work on it and if so how long will it take until the fix is merged to the latest master? A rough estimation will be sufficient, are we talking about days, weeks or even months.

Thanks

@anthonyvercolano
Copy link
Contributor

@Steiner We were talking about weeks.

@anthonyvercolano
Copy link
Contributor

@Steiner
We need to do the following:
We need to change the tss javascript library to use the newest version of ffi-napi. going from 2.4.3 -> 4.0.3
This could produce incompatible changes. I have yet to see.
I will then have to release a new version of that library (tss.js). I am not the owner of the repo.
Need to validate the various scenarios with this library.
Then release a new node SDK using the new tss.js
Node is ready to release at any moment once we get these first few issues done.
I am looking at a couple of days without interruption to get first part done. Looking at a few days to getting to a release of tss.js. Unless there are incompatible changes. (Incompatible changes could easily add a week.)
Couple of days of validation.
Couple of hours to release the SDK.

@schumajs
Copy link

Hello @anthonyvercolano, is there any update on this?

@anthonyvercolano anthonyvercolano added the IoTSDK tracks all IoT SDK issues across the board label Jun 29, 2021
@anthonyvercolano
Copy link
Contributor

Fixed in release of 09/09/21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build issue IoTSDK tracks all IoT SDK issues across the board
Projects
None yet
Development

No branches or pull requests

3 participants