Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OS Disk resize in VMSS #1906

Closed
marstr opened this issue Oct 23, 2017 · 5 comments
Closed

Add support for OS Disk resize in VMSS #1906

marstr opened this issue Oct 23, 2017 · 5 comments
Labels
Compute Service Attention Workflow: This issue is responsible by Azure service team. Service-team

Comments

@marstr
Copy link
Member

marstr commented Oct 23, 2017

In Azure/azure-sdk-for-go#818, @bpoland says:
Hi there,

Wondering if it would be possible to add support for resizing an OS disk when deploying a Virtual Machine Scale Set.

The standalone Virtual machine supports an OsDiskSizeInMB property:
https://github.com/Azure/azure-sdk-for-go/blob/c1ff18326387fa67ccc6e1b17c76e65773684227/arm/compute/models.go#L2267
However, the Scale Set is missing that property:
https://github.com/Azure/azure-sdk-for-go/blob/c1ff18326387fa67ccc6e1b17c76e65773684227/arm/compute/models.go#L1994
I have been able to deploy a scale set with an ARM template specifying a disk size property like this (using API version 2017-03-30) so I know it's possible:

"storageProfile": {
   "osDisk": {
   "caching": "ReadWrite",
   "createOption": "FromImage",
   "diskSizeGB": "10",
   "name": "[concat(variables('vmssName'), '-osp')]",
   "osType": "Linux",
   "image": {
        "uri": "[variables('vmssImageUri')]"
    }
  }
},

Hope that makes sense -- thanks!

The relevant Swagger Definitions that map to those Go declarations can be found here:

@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented May 16, 2018

@marstr 👋 any idea if this is prioritised / when this is likely to land?

@marstr
Copy link
Member Author

marstr commented May 16, 2018

Thanks for the ping on this, @tombuildsstuff! I don't have much visibility there at the moment. I've added the labels above to hopefully send it into triage. I'll keep an eye on this issue to make sure it gets addressed.

@bsiegel bsiegel added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 26, 2018
@ig-sinicyn
Copy link

ig-sinicyn commented Nov 2, 2018

Any update on this?
Ok, answering to myself. The os disk image resize works with latest api version (2018-10-01), but new image size is applied only on VM reimage

@ig-sinicyn
Copy link

UPD#2: important: the resize works only once. Any consequent deploy with different diskSizeGB will fail with Changing property 'osDisk.diskSizeGB' is not allowed error.

@Drewm3
Copy link
Member

Drewm3 commented Sep 19, 2019

Cleaning up old issues from 2016 - 2018. Please reactivate this if it is still a problem.

@Drewm3 Drewm3 closed this as completed Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compute Service Attention Workflow: This issue is responsible by Azure service team. Service-team
Projects
None yet
Development

No branches or pull requests

6 participants