Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description for the following properties for SQL MI ARM REST A… #31080

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Update description for the following properties for SQL MI ARM REST A… #31080

merged 5 commits into from
Oct 23, 2024

Conversation

UrosKrsticMIPerf
Copy link
Contributor

…PI: vCores, StorageSizeInGb and zoneRedudant, and update description of parameter sku. Hide totalMemoryMb parameter from older api versions, as it will not be used, and hasn't been used.

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • Update description for the following properties for SQL MI ARM REST API: vCores, StorageSizeInGb and zoneRedudant, and update description of parameter sku. Hide totalMemoryMb parameter from older api versions, as it will not be used, and hasn't been used.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@UrosKrsticMIPerf
Update description for the following properties for SQL MI ARM REST A…
120164b 
…PI: vCores, StorageSizeInGb and zoneRedudant, and update description of parameter sku. Hide totalMemoryMb parameter from older api versions, as it will not be used, and hasn't been used.
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 17, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 17, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/sql/armsql There is no API change compared with the previous version
JavaScript @azure/arm-sql There is no API change compared with the previous version
.Net Azure.ResourceManager.Sql https://apiview.dev/Assemblies/Review/1e3ea1e2dc2c4679b3acd45b20b81a18?revisionId=518f4e3433b34535b4e06b4b36accb15
Swagger Microsoft.Sql https://apiview.dev/Assemblies/Review/86f9467cec6a49f899d90b4872280851?revisionId=97480759da014513ba1ce711ba46c9bd

This was referenced Oct 17, 2024
Closed
Closed
Closed
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 17, 2024
@azure-sdk azure-sdk mentioned this pull request Oct 17, 2024
Closed
@ramoka178
Copy link
Contributor 

        "description": "Accepted",

please provide a description for the end user to understand easily

Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ManagedInstances.json:276 in e62235d. [](commit_id = e62235d, deletion_comment = False)

@ramoka178
Copy link
Contributor 

          "Location": {

add description for location header too. here and other places of this PR

Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ManagedInstances.json:278 in e62235d. [](commit_id = e62235d, deletion_comment = False)

@ramoka178
Copy link
Contributor 

    "x-ms-long-running-operation": true,

"x-ms-long-running-operation-options": {
"final-state-via": "location"
}

wherever missed in this PR

Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ManagedInstances.json:290 in e62235d. [](commit_id = e62235d, deletion_comment = False)

@ramoka178
Copy link
Contributor 

        "Freemium"

please add descriptions for each enum

Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ManagedInstances.json:1325 in e62235d. [](commit_id = e62235d, deletion_comment = False)

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 22, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 22, 2024
@ericshape
Copy link
Contributor

@UrosKrsticMIPerf to address the conflict, please rebase your base branch from the upstream release branch (not main branch)

@ericshape
Copy link
Contributor

and please address the comments from ARM reviewers in this swagger file as well as in the DSMainDev repo.

@UrosKrsticMIPerf
Copy link
Contributor Author 

        "description": "Accepted",

please provide a description for the end user to understand easily

Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ManagedInstances.json:276 in e62235d. [](commit_id = e62235d, deletion_comment = False)

No part of my actual change, the only change related to the 2023-08-01 and 2024-05-01 ManagedInstances.json file is the removal of totalMemoryMb parameter, everything else is reverted and removed.

@UrosKrsticMIPerf
Copy link
Contributor Author 

        "Freemium"

please add descriptions for each enum

Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ManagedInstances.json:1325 in e62235d. [](commit_id = e62235d, deletion_comment = False)

No part of my actual change, the only change related to the 2023-08-01 and 2024-05-01 ManagedInstances.json file is the removal of totalMemoryMb parameter, everything else is reverted and removed.

@UrosKrsticMIPerf
Copy link
Contributor Author 

          "Location": {

add description for location header too. here and other places of this PR

Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ManagedInstances.json:278 in e62235d. [](commit_id = e62235d, deletion_comment = False)

No part of my actual change, the only change related to the 2023-08-01 and 2024-05-01 ManagedInstances.json file is the removal of totalMemoryMb parameter, everything else is reverted and removed.

@UrosKrsticMIPerf
Copy link
Contributor Author 

        "description": "Accepted",

please provide a description for the end user to understand easily

Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ManagedInstances.json:276 in e62235d. [](commit_id = e62235d, deletion_comment = False)

No part of my actual change, the only change related to the 2023-08-01 and 2024-05-01 ManagedInstances.json file is the removal of totalMemoryMb parameter, everything else is reverted and removed.

@UrosKrsticMIPerf
Copy link
Contributor Author 

    "x-ms-long-running-operation": true,

"x-ms-long-running-operation-options": { "final-state-via": "location" }

wherever missed in this PR

Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ManagedInstances.json:290 in e62235d. [](commit_id = e62235d, deletion_comment = False)

No part of my actual change, the only change related to the 2023-08-01 and 2024-05-01 ManagedInstances.json file is the removal of totalMemoryMb parameter, everything else is reverted and removed.

@UrosKrsticMIPerf
Copy link
Contributor Author

and please address the comments from ARM reviewers in this swagger file as well as in the DSMainDev repo.

No part of my actual change, the only change related to the 2023-08-01 and 2024-05-01 ManagedInstances.json file is the removal of totalMemoryMb parameter, everything else is reverted and removed. Handled the comments.

@UrosKrsticMIPerf
Copy link
Contributor Author

@UrosKrsticMIPerf to address the conflict, please rebase your base branch from the upstream release branch (not main branch)

Rebased.

@UrosKrsticMIPerf UrosKrsticMIPerf removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 23, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 23, 2024
@ramoka178
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@ramoka178
Copy link
Contributor

Please fix the required failing checks too

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 23, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 23, 2024
@UrosKrsticMIPerf
Copy link
Contributor Author

Please fix the required failing checks too

@ramoka178 do you perhaps know why these required checks are failing? I tried looking at the details and the underlying pipeline but I see no information related to my changes to be honest.
image

@UrosKrsticMIPerf
Merge branch 'release-sql-Microsoft.Sql-2024-08-01-preview' into dev/…
5acc303 
…uroskrstic/update-sql-mi-api-property-description
@UrosKrsticMIPerf
Copy link
Contributor Author

UrosKrsticMIPerf commented Oct 23, 2024 •
edited
Loading

Please fix the required failing checks too

@ramoka178 do you perhaps know why these required checks are failing? I tried looking at the details and the underlying pipeline but I see no information related to my changes to be honest.
image

Looks like the required checks are passing now, after a rebase to the release branch.

@UrosKrsticMIPerf UrosKrsticMIPerf removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 23, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 23, 2024
@ramoka178 ramoka178 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 23, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 23, 2024
@ericshape ericshape merged commit 6987f2a into Azure:release-sql-Microsoft.Sql-2024-08-01-preview Oct 23, 2024
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericshape ericshape ericshape approved these changes

@jamestao jamestao Awaiting requested review from jamestao jamestao is a code owner

@jeremyfrosti jeremyfrosti Awaiting requested review from jeremyfrosti jeremyfrosti is a code owner

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager SQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UrosKrsticMIPerf @ramoka178 @ericshape @AzureRestAPISpecReview