Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry policy supports service-specific retry logic #5515

Open
2 tasks done
Jinming-Hu opened this issue Apr 11, 2024 · 1 comment · Fixed by #5584
Open
2 tasks done

Retry policy supports service-specific retry logic #5515

Jinming-Hu opened this issue Apr 11, 2024 · 1 comment · Fixed by #5584
Assignees
Labels
Azure.Core feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@Jinming-Hu
Copy link
Member

Is your feature request related to a problem? Please describe.

Storage team needs this feature for one of STG94 features.
We need to decide whether or not to retry a response based on a new response header x-ms-copy-source-error-code.

Describe the solution you'd like

Add an optional field into RetryOptions. This field is a lambda function, taking a raw response as parameter. Service sdk can set this field and add some service-specific logic to determine if a response should be retried.

Describe alternatives you've considered

Something similar to ResponseClassifier in .Net SDK
https://github.com/Azure/azure-sdk-for-net/blob/bb90af89e27be84541e142a4ffd648825a2fdbe2/sdk/storage/Azure.Storage.Common/src/Shared/StorageResponseClassifier.cs

Additional context

None

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@ahsonkhan
Copy link
Member

ahsonkhan commented Jul 9, 2024

Re-opening since we made RetryPolicy final again, until Storage needs the customization feature: #5771
We'll revisit this for STG98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
3 participants