Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong wording in HTTPRange doc #22054

Closed
tomyl opened this issue Nov 24, 2023 · 4 comments · Fixed by #22117
Closed

Wrong wording in HTTPRange doc #22054

tomyl opened this issue Nov 24, 2023 · 4 comments · Fixed by #22117
Assignees
Labels
AzBlob customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)

Comments

@tomyl
Copy link

tomyl commented Nov 24, 2023

// HTTPRange defines a range of bytes within an HTTP resource, starting at offset and
// ending at offset+count. A zero-value HTTPRange indicates the entire resource. An HTTPRange
// which has an offset but no zero value count indicates from the offset to the resource's end.

Shouldn't it say

An HTTPRange which has an offset but a zero value count indicates from the offset to the resource's end.
?

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-triage Workflow: This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files) labels Nov 24, 2023
@vibhansa-msft
Copy link
Member

"A zero-value HTTPRange indicates the entire resource." : it mentions the same, which part you feel is wrong here ?

@vibhansa-msft vibhansa-msft self-assigned this Nov 27, 2023
@tomyl
Copy link
Author

tomyl commented Nov 27, 2023

"A zero-value HTTPRange indicates the entire resource." : it mentions the same, which part you feel is wrong here ?

The last sentence in the doc which I believe refers to the case when Offset > 1 and Count == 0 however the doc says but no zero value count which I interpret as Count != 0.

@jhendrixMSFT jhendrixMSFT added Docs and removed Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. labels Nov 27, 2023
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Nov 27, 2023
@vibhansa-msft
Copy link
Member

If offset is given and count = 0 then we read till end, if count is given then only those many bytes are read.

@souravgupta-msft
Copy link
Member

@tomyl, thanks for pointing this. The doc has been updated.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AzBlob customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants