Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation logic should dynamically pull Swagger specs (or they should be vendored into this repo) #516

Closed
colemickens opened this issue Jan 25, 2017 · 3 comments
Assignees

Comments

@colemickens
Copy link
Contributor

colemickens commented Jan 25, 2017

Example:

The KeyVault swagger was updated to include the data plane, but newest versions of the Go SDK don't have the new functionality.

Looking at this: https://github.com/Azure/azure-sdk-for-go/blob/master/Gododir/gen.go it seems that the Swaggers are downloaded manually.

It seems that someone pulled the Swagger spec for KeyVault down, but missed the fact that it's since been updated. Since this is error prone, instead, the script should download the swagger specs ahead of calling Autorest.

@colemickens
Copy link
Contributor Author

cc: @mbearup

@marstr
Copy link
Member

marstr commented Jan 25, 2017

Totally agreed. We're actively looking at ways to improve this story. Ideally, we wouldn't have a manual monthly release, but rather react to changes in swaggers with automatic releases. There is a similar thread that is open here: #476.

For now, I believe this is a duplicate suggestion to the issue above. If you agree, please close out the issue.

@marstr marstr assigned marstr and colemickens and unassigned marstr Jan 25, 2017
@colemickens
Copy link
Contributor Author

makes sense. thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants