Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for ServiceBusErrorSource in SB Track2 #16711

Closed
hemanttanwar opened this issue Oct 22, 2020 · 2 comments
Closed

Add API for ServiceBusErrorSource in SB Track2 #16711

hemanttanwar opened this issue Oct 22, 2020 · 2 comments
Assignees
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@hemanttanwar
Copy link
Contributor

hemanttanwar commented Oct 22, 2020

Introduce ServiceBusErrorSource, to help user identify source of the error. Specially in error handler in processor model.

For example

public enum ServiceBusErrorSource {
RECEIVE,
APPEND,
COMPLETE,
DEFER,
DEAD_LETTER,
}

@hemanttanwar hemanttanwar added Client This issue points to a problem in the data-plane of the library. Service Bus labels Oct 22, 2020
@hemanttanwar hemanttanwar added this to the [2020] November milestone Oct 22, 2020
@hemanttanwar hemanttanwar self-assigned this Oct 22, 2020
@hemanttanwar hemanttanwar added the blocking-release Blocks release label Oct 22, 2020
@hemanttanwar hemanttanwar changed the title Add API for ServiceBusErrorSource in SB Track1 Add API for ServiceBusErrorSource in SB Track2 Oct 26, 2020
@ramya-rao-a
Copy link
Contributor

Originally, the error source came as a requirement to identify the source of the errors coming from background processes that tend to be applicable to

  • receiving in the async client
  • the processor model

Therefore, the only error sources we would need are

  • complete (from when we try to auto complete)
  • abandon (from when we try to abandon if user's callback failed)
  • receive (from when we try to receive a message to pass to user's callback)
  • renewLock (from when we try to renew lock for the received messages)
  • user callback (from user's message callback)
  • accepting a new session (when receiving from multiple sessions and we roll over to get a new session)

cc @hemanttanwar, @YijunXieMS, @conniey, @srnagar

@ramya-rao-a
Copy link
Contributor

Done with #16710

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

No branches or pull requests

2 participants