We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tested this on both core V1 and core V2 - it looks like tracingPolicy is only run once regardless of number of retries.
To reproduce (using Key Vault as an example):
async function main(): Promise<void> { const provider = new NodeTracerProvider(); provider.addSpanProcessor(new SimpleSpanProcessor(new ConsoleSpanExporter())); provider.register(); const tracer = provider.getTracer("my-service"); const keyClient = new KeyClient("<KEYVAULT_NAME>", new AzureCliCredential(), { retryOptions: { maxRetries: 2, }, }); await tracer.startActiveSpan("root", async (span) => { await keyClient.createEcKey("retry"); }); }
Then modify exponentialRetryPolicy to always retry up to the retryCount (easier than setting up the retry conditions).
Expected:
Actual:
Note: haven't had a chance to dig into the root cause yet - would we just need to reorder policies in coreHttp and coreClient?
The text was updated successfully, but these errors were encountered:
This might get fixed by #19078 thanks to @sadasant 😄
This is fine to parent against Azure Core Fundamentals for JS IMO - it won't block core-tracing GA
Sorry, something went wrong.
sadasant
maorleger
Successfully merging a pull request may close this issue.
Tested this on both core V1 and core V2 - it looks like tracingPolicy is only run once regardless of number of retries.
To reproduce (using Key Vault as an example):
Then modify exponentialRetryPolicy to always retry up to the retryCount (easier than setting up the retry conditions).
Expected:
Actual:
Note: haven't had a chance to dig into the root cause yet - would we just need to reorder policies in coreHttp and coreClient?
The text was updated successfully, but these errors were encountered: