Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable spatial types support in Search #13319

Closed
AlexGhiondea opened this issue Jul 8, 2020 · 3 comments
Closed

Enable spatial types support in Search #13319

AlexGhiondea opened this issue Jul 8, 2020 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone

Comments

@AlexGhiondea
Copy link
Contributor

Once the Azure Core change (#10592) is merged, we need to re-enabled the APIs in Search to support it.

@AlexGhiondea AlexGhiondea added Client This issue points to a problem in the data-plane of the library. Search labels Jul 8, 2020
@AlexGhiondea AlexGhiondea added this to the [2020] August milestone Jul 8, 2020
@heaths heaths modified the milestones: [2020] October, Backlog Sep 21, 2020
@heaths
Copy link
Member

heaths commented Sep 24, 2020

When we do this, we could remove the proxy classes for Microsoft.Spatial and instead use adapters to create GeoJson types. This would not only reduce the amount of code to maintain, but also remove the intentional duplication in SpatialFormatter to improve perf (no reason to allocate extra).

@AlexGhiondea
Copy link
Contributor Author

This is done now.

@heaths
Copy link
Member

heaths commented Oct 7, 2021

The proxies for Microsoft.Spatial still exist but the comment implies the intention was to remove them. That's not what we actually want to do, though, right? So we can still support Microsoft.Spatial types? Maybe the comment is just misleading.

/cc @tg-msft @Mohit-Chakraborty @brjohnstmsft

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Development

No branches or pull requests

3 participants