From abe0cf189f15dbf525c637ad0c35fd5ca508dd84 Mon Sep 17 00:00:00 2001 From: Caio Saldanha Date: Tue, 2 Jun 2020 09:35:55 -0700 Subject: [PATCH 1/2] remove lros --- .../Azure.AI.FormRecognizer/src/CopyModelOperation.cs | 8 -------- .../src/RecognizeContentOperation.cs | 7 ------- .../src/RecognizeCustomFormsOperation.cs | 7 ------- .../src/RecognizeReceiptsOperation.cs | 7 ------- .../Azure.AI.FormRecognizer/src/TrainingOperation.cs | 7 ------- 5 files changed, 36 deletions(-) diff --git a/sdk/formrecognizer/Azure.AI.FormRecognizer/src/CopyModelOperation.cs b/sdk/formrecognizer/Azure.AI.FormRecognizer/src/CopyModelOperation.cs index 0d15d37b21f25..2b3795da67660 100644 --- a/sdk/formrecognizer/Azure.AI.FormRecognizer/src/CopyModelOperation.cs +++ b/sdk/formrecognizer/Azure.AI.FormRecognizer/src/CopyModelOperation.cs @@ -116,14 +116,6 @@ internal CopyModelOperation(ServiceRestClient serviceClient, ClientDiagnostics d Id = string.Join("/", substrs, substrs.Length - 3, 3); } - /// - /// Initializes a new instance of the class. - /// - protected CopyModelOperation() - { - } - - /// public override Response GetRawResponse() => _response; diff --git a/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeContentOperation.cs b/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeContentOperation.cs index 10d3aecf7d358..ce275c0485857 100644 --- a/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeContentOperation.cs +++ b/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeContentOperation.cs @@ -68,13 +68,6 @@ internal RecognizeContentOperation(ServiceRestClient serviceClient, string opera Id = operationLocation.Split('/').Last(); } - /// - /// Initializes a new instance of the class. - /// - protected RecognizeContentOperation() - { - } - /// public override Response GetRawResponse() => _response; diff --git a/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeCustomFormsOperation.cs b/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeCustomFormsOperation.cs index 8b7124e116fcd..5a30036618476 100644 --- a/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeCustomFormsOperation.cs +++ b/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeCustomFormsOperation.cs @@ -114,13 +114,6 @@ public RecognizeCustomFormsOperation(string operationId, FormRecognizerClient cl Id = operationId; } - /// - /// Initializes a new instance of the class. - /// - protected RecognizeCustomFormsOperation() - { - } - /// public override Response UpdateStatus(CancellationToken cancellationToken = default) => UpdateStatusAsync(false, cancellationToken).EnsureCompleted(); diff --git a/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeReceiptsOperation.cs b/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeReceiptsOperation.cs index 6fe938291d678..7b14c15f8c894 100644 --- a/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeReceiptsOperation.cs +++ b/sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeReceiptsOperation.cs @@ -70,13 +70,6 @@ internal RecognizeReceiptsOperation(ServiceRestClient serviceClient, string oper Id = operationLocation.Split('/').Last(); } - /// - /// Initializes a new instance of the class. - /// - protected RecognizeReceiptsOperation() - { - } - /// public override ValueTask> WaitForCompletionAsync(CancellationToken cancellationToken = default) => this.DefaultWaitForCompletionAsync(cancellationToken); diff --git a/sdk/formrecognizer/Azure.AI.FormRecognizer/src/TrainingOperation.cs b/sdk/formrecognizer/Azure.AI.FormRecognizer/src/TrainingOperation.cs index 010e883bdb078..b3ed982221709 100644 --- a/sdk/formrecognizer/Azure.AI.FormRecognizer/src/TrainingOperation.cs +++ b/sdk/formrecognizer/Azure.AI.FormRecognizer/src/TrainingOperation.cs @@ -53,13 +53,6 @@ public override ValueTask> WaitForCompletionAsync(Canc public override ValueTask> WaitForCompletionAsync(TimeSpan pollingInterval, CancellationToken cancellationToken = default) => this.DefaultWaitForCompletionAsync(pollingInterval, cancellationToken); - /// - /// Initializes a new instance of the class for mocking. - /// - protected TrainingOperation() - { - } - internal TrainingOperation(string location, ServiceRestClient allOperations) { _serviceClient = allOperations; From 426ed8a685f215c5523efcab963df2729aa7db3f Mon Sep 17 00:00:00 2001 From: Caio Saldanha Date: Tue, 2 Jun 2020 09:38:43 -0700 Subject: [PATCH 2/2] docs --- sdk/formrecognizer/Azure.AI.FormRecognizer/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/sdk/formrecognizer/Azure.AI.FormRecognizer/CHANGELOG.md b/sdk/formrecognizer/Azure.AI.FormRecognizer/CHANGELOG.md index dcb4c432f480b..840087b438dbc 100644 --- a/sdk/formrecognizer/Azure.AI.FormRecognizer/CHANGELOG.md +++ b/sdk/formrecognizer/Azure.AI.FormRecognizer/CHANGELOG.md @@ -27,6 +27,7 @@ - In preparation for service-side changes, `FieldValue.AsInt32` has been replaced by `FieldValue.AsInt64`, which returns a `long`. - The order of the values for `USReceiptType` have changed so that `Other` has now a value of `1`. - Parameter `useTrainingLabels` is now required for `FormTrainingClient.StartTraining`. +- Protected constructors have been removed from `Operation` types, such as `TrainingOperation` or `RecognizeContentOperation`. ### New Features