From cbca490948c3efd5599270fd3b2f2ffa5a8d8bad Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Mon, 11 Nov 2024 11:57:15 +0800
Subject: [PATCH 1/5] Apply RequestContext for PrcessMessage

---
 eng/Packages.Data.props                       |  2 +-
 .../Azure.Generator/src/AzureClientPlugin.cs  |  4 ++
 .../Azure.Generator/src/AzureOutputLibrary.cs | 20 +++++++
 .../Abstraction/HttpMessageProvider.cs        |  3 --
 .../Abstraction/HttpPipelineProvider.cs       | 41 ++++++++++++--
 .../RequestContextExtensionsDefinition.cs     | 53 +++++++++++++++++++
 .../src/Generated/BasicTypeSpecClient.cs      | 48 ++++++++---------
 .../Internal/ClientPipelineExtensions.cs      | 19 +++----
 .../Internal/RequestContextExtensions.cs      | 25 +++++++++
 .../Generated/Models/FloatExtensibleEnum.cs   |  1 +
 .../Models/FloatExtensibleEnumWithIntValue.cs |  1 +
 .../src/Generated/Models/IntExtensibleEnum.cs |  1 +
 .../Generated/Models/StringExtensibleEnum.cs  |  1 +
 .../Models/ThingOptionalLiteralFloat.cs       |  1 +
 .../Models/ThingOptionalLiteralInt.cs         |  1 +
 .../Models/ThingOptionalLiteralString.cs      |  1 +
 .../Models/ThingRequiredLiteralFloat.cs       |  1 +
 .../Models/ThingRequiredLiteralInt.cs         |  1 +
 .../Models/ThingRequiredLiteralString.cs      |  1 +
 19 files changed, 181 insertions(+), 44 deletions(-)
 create mode 100644 eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs
 create mode 100644 eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/RequestContextExtensionsDefinition.cs
 create mode 100644 eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/RequestContextExtensions.cs

diff --git a/eng/Packages.Data.props b/eng/Packages.Data.props
index 1d290bfe11090..3bf8291725d35 100644
--- a/eng/Packages.Data.props
+++ b/eng/Packages.Data.props
@@ -252,7 +252,7 @@
   </ItemGroup>
 
   <ItemGroup Condition="'$(IsGeneratorLibrary)' == 'true'">
-    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241030.4" />
+    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241110.3" />
   </ItemGroup>
 
   <!--
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureClientPlugin.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureClientPlugin.cs
index e1041af28cf05..c24325be35538 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureClientPlugin.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureClientPlugin.cs
@@ -24,6 +24,10 @@ public class AzureClientPlugin : ClientModelPlugin
     /// <inheritdoc/>
     public override AzureTypeFactory TypeFactory { get; }
 
+    private AzureOutputLibrary? _azureOutputLibrary;
+    /// <inheritdoc/>
+    public override OutputLibrary OutputLibrary => _azureOutputLibrary ??= new();
+
     /// <summary>
     /// The Azure client plugin to generate the Azure client SDK.
     /// </summary>
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs
new file mode 100644
index 0000000000000..99aff3ebb5c86
--- /dev/null
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs
@@ -0,0 +1,20 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using Azure.Generator.Providers;
+using Microsoft.Generator.CSharp.ClientModel;
+using Microsoft.Generator.CSharp.Providers;
+
+namespace Azure.Generator
+{
+    /// <inheritdoc/>
+    public class AzureOutputLibrary : ScmOutputLibrary
+    {
+        /// <inheritdoc/>
+        protected override TypeProvider[] BuildTypeProviders()
+            => [
+                ..base.BuildTypeProviders(),
+                new RequestContextExtensionsDefinition(),
+            ];
+    }
+}
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs
index 95ffb0b02cd21..c8113b69c4848 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs
@@ -24,9 +24,6 @@ public HttpMessageProvider(ValueExpression original) : base(typeof(HttpMessage),
         public override ValueExpression BufferResponse()
             => Original.Property(nameof(HttpMessage.BufferResponse));
 
-        public override MethodBodyStatement[] ExtractResponse()
-            => [Original.Invoke(nameof(HttpMessage.ExtractResponseContent)).Terminate(), Return(Original.Property(nameof(HttpMessage.Response)))];
-
         public override HttpMessageApi FromExpression(ValueExpression original)
             => new HttpMessageProvider(original);
 
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
index 05d90170eea48..b983bd9f3881f 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
@@ -6,7 +6,10 @@
 using Microsoft.Generator.CSharp.ClientModel.Providers;
 using Microsoft.Generator.CSharp.Expressions;
 using Microsoft.Generator.CSharp.Primitives;
+using Microsoft.Generator.CSharp.Providers;
+using Microsoft.Generator.CSharp.Snippets;
 using Microsoft.Generator.CSharp.Statements;
+using System.Threading;
 using static Microsoft.Generator.CSharp.Snippets.Snippet;
 
 namespace Azure.Generator.Providers.Abstraction
@@ -40,10 +43,40 @@ public override ValueExpression PerRetryPolicy(params ValueExpression[] argument
 
         public override ClientPipelineApi ToExpression() => this;
 
-        public override MethodBodyStatement Send(HttpMessageApi message, HttpRequestOptionsApi options)
-            => Original.Invoke(nameof(HttpPipeline.Send), [message, Default]).Terminate();
+        public override MethodBodyStatement[] ProcessMessage(HttpMessageApi message, HttpRequestOptionsApi options)
+        {
+            var userCacellationToken = new ParameterProvider("userCancellationToken", $"", new CSharpType(typeof(CancellationToken)));
+            var statusOption = new ParameterProvider("statusOption", $"", new CSharpType(typeof(ErrorOptions)));
+            return new MethodBodyStatement[]
+            {
+                new VariableTupleExpression(false, userCacellationToken, statusOption).Assign(options.Invoke("Parse")).Terminate(),
+                Original.Invoke(nameof(HttpPipeline.Send), [message, userCacellationToken]).Terminate(),
+                MethodBodyStatement.EmptyLine,
+                new IfStatement(message.Response().IsError().And(new BinaryOperatorExpression("&", options.NullConditional().Property("ErrorOptions"), options.NoThrow()).NotEqual(options.NoThrow())))
+                {
+                    Throw(New.Instance(AzureClientPlugin.Instance.TypeFactory.ClientResponseApi.ClientResponseExceptionType, message.Response()))
+                },
+                MethodBodyStatement.EmptyLine,
+                Return(message.Response())
+            };
+        }
 
-        public override MethodBodyStatement SendAsync(HttpMessageApi message, HttpRequestOptionsApi options)
-            => Original.Invoke(nameof(HttpPipeline.SendAsync), [message, Default], true).Terminate();
+        public override MethodBodyStatement[] ProcessMessageAsync(HttpMessageApi message, HttpRequestOptionsApi options)
+        {
+            var userCacellationToken = new ParameterProvider("userCancellationToken", $"", new CSharpType(typeof(CancellationToken)));
+            var statusOption = new ParameterProvider("statusOption", $"", new CSharpType(typeof(ErrorOptions)));
+            return new MethodBodyStatement[]
+            {
+                new VariableTupleExpression(false, userCacellationToken, statusOption).Assign(options.Invoke("Parse")).Terminate(),
+                Original.Invoke(nameof(HttpPipeline.SendAsync), [message, userCacellationToken], true).Terminate(),
+                MethodBodyStatement.EmptyLine,
+                new IfStatement(message.Response().IsError().And(new BinaryOperatorExpression("&", options.NullConditional().Property("ErrorOptions"), options.NoThrow()).NotEqual(options.NoThrow())))
+                {
+                    Throw(AzureClientPlugin.Instance.TypeFactory.ClientResponseApi.ToExpression().CreateAsync(message.Response()))
+                },
+                MethodBodyStatement.EmptyLine,
+                Return(message.Response())
+            };
+        }
     }
 }
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/RequestContextExtensionsDefinition.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/RequestContextExtensionsDefinition.cs
new file mode 100644
index 0000000000000..8f3994b00da6a
--- /dev/null
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/RequestContextExtensionsDefinition.cs
@@ -0,0 +1,53 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using Microsoft.Generator.CSharp.Expressions;
+using Microsoft.Generator.CSharp.Primitives;
+using Microsoft.Generator.CSharp.Providers;
+using Microsoft.Generator.CSharp.Snippets;
+using Microsoft.Generator.CSharp.Statements;
+using System.IO;
+using System.Threading;
+using static Microsoft.Generator.CSharp.Snippets.Snippet;
+
+namespace Azure.Generator.Providers
+{
+    internal class RequestContextExtensionsDefinition : TypeProvider
+    {
+        protected override TypeSignatureModifiers GetDeclarationModifiers() => TypeSignatureModifiers.Internal | TypeSignatureModifiers.Static;
+
+        protected override string BuildName() => "RequestContextExtensions";
+
+        protected override string BuildRelativeFilePath() => Path.Combine("src", "Generated", "Internal", $"{Name}.cs");
+
+        protected override MethodProvider[] BuildMethods()
+        {
+            return
+            [
+                BuildParse()
+            ];
+        }
+
+        private MethodProvider BuildParse()
+        {
+            var requestContextParameter = new ParameterProvider("requestContext", $"", typeof(RequestContext));
+            var signature = new MethodSignature(
+                "Parse",
+                null,
+                MethodSignatureModifiers.Public | MethodSignatureModifiers.Static | MethodSignatureModifiers.Extension,
+                new CSharpType(typeof((CancellationToken, ErrorOptions))),
+                null,
+                [requestContextParameter]);
+
+            var method = new MethodProvider(signature, new MethodBodyStatement[]
+            {
+                new IfStatement(requestContextParameter.Equal(Null))
+                {
+                    Return(new TupleExpression(Static<CancellationToken>().Property(nameof(CancellationToken.None)), Static<ErrorOptions>().Property(nameof(ErrorOptions.Default))))
+                },
+                Return(new TupleExpression(requestContextParameter.Property(nameof(RequestContext.CancellationToken)), requestContextParameter.Property(nameof(RequestContext.ErrorOptions))))
+            }, this);
+            return method;
+        }
+    }
+}
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.cs
index 20b2d3635f262..d4947a28673c1 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.cs
@@ -68,12 +68,12 @@ public BasicTypeSpecClient(Uri endpoint, ApiKeyCredential keyCredential, BasicTy
         /// </summary>
         /// <param name="headParameter"></param>
         /// <param name="queryParameter"></param>
-        /// <param name="optionalQuery"></param>
         /// <param name="context"> The request options, which can override default behaviors of the client pipeline on a per-call basis. </param>
+        /// <param name="optionalQuery"></param>
         /// <exception cref="ArgumentNullException"> <paramref name="headParameter"/> or <paramref name="queryParameter"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual Response SayHi(string headParameter, string queryParameter, string optionalQuery, RequestContext context)
+        public virtual Response SayHi(string headParameter, string queryParameter, RequestContext context, string optionalQuery = null)
         {
             Argument.AssertNotNull(headParameter, nameof(headParameter));
             Argument.AssertNotNull(queryParameter, nameof(queryParameter));
@@ -92,12 +92,12 @@ public virtual Response SayHi(string headParameter, string queryParameter, strin
         /// </summary>
         /// <param name="headParameter"></param>
         /// <param name="queryParameter"></param>
-        /// <param name="optionalQuery"></param>
         /// <param name="context"> The request options, which can override default behaviors of the client pipeline on a per-call basis. </param>
+        /// <param name="optionalQuery"></param>
         /// <exception cref="ArgumentNullException"> <paramref name="headParameter"/> or <paramref name="queryParameter"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual async Task<Response> SayHiAsync(string headParameter, string queryParameter, string optionalQuery, RequestContext context)
+        public virtual async Task<Response> SayHiAsync(string headParameter, string queryParameter, RequestContext context, string optionalQuery = null)
         {
             Argument.AssertNotNull(headParameter, nameof(headParameter));
             Argument.AssertNotNull(queryParameter, nameof(queryParameter));
@@ -112,12 +112,12 @@ public virtual async Task<Response> SayHiAsync(string headParameter, string quer
         /// <param name="optionalQuery"></param>
         /// <exception cref="ArgumentNullException"> <paramref name="headParameter"/> or <paramref name="queryParameter"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
-        public virtual Response<Thing> SayHi(string headParameter, string queryParameter, string optionalQuery)
+        public virtual Response<Thing> SayHi(string headParameter, string queryParameter, string optionalQuery = null)
         {
             Argument.AssertNotNull(headParameter, nameof(headParameter));
             Argument.AssertNotNull(queryParameter, nameof(queryParameter));
 
-            Response result = SayHi(headParameter, queryParameter, optionalQuery, null);
+            Response result = SayHi(headParameter, queryParameter, null, optionalQuery);
             return Response.FromValue((Thing)result, result);
         }
 
@@ -127,12 +127,12 @@ public virtual Response<Thing> SayHi(string headParameter, string queryParameter
         /// <param name="optionalQuery"></param>
         /// <exception cref="ArgumentNullException"> <paramref name="headParameter"/> or <paramref name="queryParameter"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
-        public virtual async Task<Response<Thing>> SayHiAsync(string headParameter, string queryParameter, string optionalQuery)
+        public virtual async Task<Response<Thing>> SayHiAsync(string headParameter, string queryParameter, string optionalQuery = null)
         {
             Argument.AssertNotNull(headParameter, nameof(headParameter));
             Argument.AssertNotNull(queryParameter, nameof(queryParameter));
 
-            Response result = await SayHiAsync(headParameter, queryParameter, optionalQuery, null).ConfigureAwait(false);
+            Response result = await SayHiAsync(headParameter, queryParameter, null, optionalQuery).ConfigureAwait(false);
             return Response.FromValue((Thing)result, result);
         }
 
@@ -151,7 +151,7 @@ public virtual async Task<Response<Thing>> SayHiAsync(string headParameter, stri
         /// <exception cref="ArgumentNullException"> <paramref name="p2"/>, <paramref name="p1"/> or <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual Response HelloAgain(string p2, string p1, RequestContent content, RequestContext context)
+        public virtual Response HelloAgain(string p2, string p1, RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(p2, nameof(p2));
             Argument.AssertNotNull(p1, nameof(p1));
@@ -176,7 +176,7 @@ public virtual Response HelloAgain(string p2, string p1, RequestContent content,
         /// <exception cref="ArgumentNullException"> <paramref name="p2"/>, <paramref name="p1"/> or <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual async Task<Response> HelloAgainAsync(string p2, string p1, RequestContent content, RequestContext context)
+        public virtual async Task<Response> HelloAgainAsync(string p2, string p1, RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(p2, nameof(p2));
             Argument.AssertNotNull(p1, nameof(p1));
@@ -233,7 +233,7 @@ public virtual async Task<Response<RoundTripModel>> HelloAgainAsync(string p2, s
         /// <exception cref="ArgumentNullException"> <paramref name="p2"/>, <paramref name="p1"/> or <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual Response NoContentType(string p2, string p1, RequestContent content, RequestContext context)
+        public virtual Response NoContentType(string p2, string p1, RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(p2, nameof(p2));
             Argument.AssertNotNull(p1, nameof(p1));
@@ -258,7 +258,7 @@ public virtual Response NoContentType(string p2, string p1, RequestContent conte
         /// <exception cref="ArgumentNullException"> <paramref name="p2"/>, <paramref name="p1"/> or <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual async Task<Response> NoContentTypeAsync(string p2, string p1, RequestContent content, RequestContext context)
+        public virtual async Task<Response> NoContentTypeAsync(string p2, string p1, RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(p2, nameof(p2));
             Argument.AssertNotNull(p1, nameof(p1));
@@ -331,7 +331,7 @@ public virtual async Task<Response<Thing>> HelloDemo2Async()
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual Response CreateLiteral(RequestContent content, RequestContext context)
+        public virtual Response CreateLiteral(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
@@ -352,7 +352,7 @@ public virtual Response CreateLiteral(RequestContent content, RequestContext con
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual async Task<Response> CreateLiteralAsync(RequestContent content, RequestContext context)
+        public virtual async Task<Response> CreateLiteralAsync(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
@@ -535,7 +535,7 @@ public virtual async Task<Response> TopAction2Async(RequestContext context)
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual Response PatchAction(RequestContent content, RequestContext context)
+        public virtual Response PatchAction(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
@@ -556,7 +556,7 @@ public virtual Response PatchAction(RequestContent content, RequestContext conte
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual async Task<Response> PatchActionAsync(RequestContent content, RequestContext context)
+        public virtual async Task<Response> PatchActionAsync(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
@@ -577,7 +577,7 @@ public virtual async Task<Response> PatchActionAsync(RequestContent content, Req
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual Response AnonymousBody(RequestContent content, RequestContext context)
+        public virtual Response AnonymousBody(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
@@ -598,7 +598,7 @@ public virtual Response AnonymousBody(RequestContent content, RequestContext con
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual async Task<Response> AnonymousBodyAsync(RequestContent content, RequestContext context)
+        public virtual async Task<Response> AnonymousBodyAsync(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
@@ -701,7 +701,7 @@ public virtual async Task<Response<Thing>> AnonymousBodyAsync(string name, Binar
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual Response FriendlyModel(RequestContent content, RequestContext context)
+        public virtual Response FriendlyModel(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
@@ -722,7 +722,7 @@ public virtual Response FriendlyModel(RequestContent content, RequestContext con
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual async Task<Response> FriendlyModelAsync(RequestContent content, RequestContext context)
+        public virtual async Task<Response> FriendlyModelAsync(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
@@ -817,7 +817,7 @@ public virtual async Task<Response> AddTimeHeaderAsync()
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual Response ProjectedNameModel(RequestContent content, RequestContext context)
+        public virtual Response ProjectedNameModel(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
@@ -838,7 +838,7 @@ public virtual Response ProjectedNameModel(RequestContent content, RequestContex
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual async Task<Response> ProjectedNameModelAsync(RequestContent content, RequestContext context)
+        public virtual async Task<Response> ProjectedNameModelAsync(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
@@ -1001,7 +1001,7 @@ public virtual async Task<Response<string>> GetUnknownValueAsync(string accept)
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual Response InternalProtocol(RequestContent content, RequestContext context)
+        public virtual Response InternalProtocol(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
@@ -1022,7 +1022,7 @@ public virtual Response InternalProtocol(RequestContent content, RequestContext
         /// <exception cref="ArgumentNullException"> <paramref name="content"/> is null. </exception>
         /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
         /// <returns> The response returned from the service. </returns>
-        public virtual async Task<Response> InternalProtocolAsync(RequestContent content, RequestContext context)
+        public virtual async Task<Response> InternalProtocolAsync(RequestContent content, RequestContext context = null)
         {
             Argument.AssertNotNull(content, nameof(content));
 
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
index 0df6739148f78..568fc53b8f445 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
@@ -5,6 +5,7 @@
 
 #nullable disable
 
+using System.Threading;
 using System.Threading.Tasks;
 using Azure;
 using Azure.Core;
@@ -16,28 +17,28 @@ internal static partial class ClientPipelineExtensions
     {
         public static async ValueTask<Response> ProcessMessageAsync(this HttpPipeline pipeline, HttpMessage message, RequestContext context)
         {
-            await pipeline.SendAsync(message, default).ConfigureAwait(false);
+            (CancellationToken userCancellationToken, ErrorOptions statusOption) = context.Parse();
+            await pipeline.SendAsync(message, userCancellationToken).ConfigureAwait(false);
 
             if (message.Response.IsError && (context?.ErrorOptions & ErrorOptions.NoThrow) != ErrorOptions.NoThrow)
             {
                 throw new RequestFailedException(message.Response);
             }
 
-            Response response = message.BufferResponse ? message.Response : ExtractResponseContent(message);
-            return response;
+            return message.Response;
         }
 
         public static Response ProcessMessage(this HttpPipeline pipeline, HttpMessage message, RequestContext context)
         {
-            pipeline.Send(message, default);
+            (CancellationToken userCancellationToken, ErrorOptions statusOption) = context.Parse();
+            pipeline.Send(message, userCancellationToken);
 
             if (message.Response.IsError && (context?.ErrorOptions & ErrorOptions.NoThrow) != ErrorOptions.NoThrow)
             {
                 throw new RequestFailedException(message.Response);
             }
 
-            Response response = message.BufferResponse ? message.Response : ExtractResponseContent(message);
-            return response;
+            return message.Response;
         }
 
         public static async ValueTask<Response<bool>> ProcessHeadAsBoolMessageAsync(this HttpPipeline pipeline, HttpMessage message, RequestContext context)
@@ -67,11 +68,5 @@ public static Response<bool> ProcessHeadAsBoolMessage(this HttpPipeline pipeline
                     return new ErrorResult<bool>(response, new RequestFailedException(response));
             }
         }
-
-        private static Response ExtractResponseContent(HttpMessage message)
-        {
-            message.ExtractResponseContent();
-            return message.Response;
-        }
     }
 }
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/RequestContextExtensions.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/RequestContextExtensions.cs
new file mode 100644
index 0000000000000..d44e4ab95b6b5
--- /dev/null
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/RequestContextExtensions.cs
@@ -0,0 +1,25 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+// <auto-generated/>
+
+#nullable disable
+
+using System;
+using System.Threading;
+using Azure;
+
+namespace BasicTypeSpec
+{
+    internal static partial class RequestContextExtensions
+    {
+        public static ValueTuple<CancellationToken, ErrorOptions> Parse(this RequestContext requestContext)
+        {
+            if (requestContext == null)
+            {
+                return (CancellationToken.None, ErrorOptions.Default);
+            }
+            return (requestContext.CancellationToken, requestContext.ErrorOptions);
+        }
+    }
+}
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/FloatExtensibleEnum.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/FloatExtensibleEnum.cs
index 1ea90f23f92bf..0cf1f4d44b23b 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/FloatExtensibleEnum.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/FloatExtensibleEnum.cs
@@ -57,6 +57,7 @@ public FloatExtensibleEnum(float value)
         public bool Equals(FloatExtensibleEnum other) => Equals(_value, other._value);
 
         /// <inheritdoc/>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public override int GetHashCode() => _value.GetHashCode();
 
         /// <inheritdoc/>
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/FloatExtensibleEnumWithIntValue.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/FloatExtensibleEnumWithIntValue.cs
index 021f057db2cd8..8b6b3d4e43bd7 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/FloatExtensibleEnumWithIntValue.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/FloatExtensibleEnumWithIntValue.cs
@@ -57,6 +57,7 @@ public FloatExtensibleEnumWithIntValue(float value)
         public bool Equals(FloatExtensibleEnumWithIntValue other) => Equals(_value, other._value);
 
         /// <inheritdoc/>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public override int GetHashCode() => _value.GetHashCode();
 
         /// <inheritdoc/>
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/IntExtensibleEnum.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/IntExtensibleEnum.cs
index 70662256d1a8d..3ca6e3ebea685 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/IntExtensibleEnum.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/IntExtensibleEnum.cs
@@ -57,6 +57,7 @@ public IntExtensibleEnum(int value)
         public bool Equals(IntExtensibleEnum other) => Equals(_value, other._value);
 
         /// <inheritdoc/>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public override int GetHashCode() => _value.GetHashCode();
 
         /// <inheritdoc/>
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/StringExtensibleEnum.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/StringExtensibleEnum.cs
index a2c32dfebf119..d04ef36841b3c 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/StringExtensibleEnum.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/StringExtensibleEnum.cs
@@ -60,6 +60,7 @@ public StringExtensibleEnum(string value)
         public bool Equals(StringExtensibleEnum other) => string.Equals(_value, other._value, StringComparison.InvariantCultureIgnoreCase);
 
         /// <inheritdoc/>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public override int GetHashCode() => _value != null ? StringComparer.InvariantCultureIgnoreCase.GetHashCode(_value) : 0;
 
         /// <inheritdoc/>
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralFloat.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralFloat.cs
index 11af4e2057adf..8bdecf41d8e13 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralFloat.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralFloat.cs
@@ -50,6 +50,7 @@ public ThingOptionalLiteralFloat(float value)
         public bool Equals(ThingOptionalLiteralFloat other) => Equals(_value, other._value);
 
         /// <inheritdoc/>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public override int GetHashCode() => _value.GetHashCode();
 
         /// <inheritdoc/>
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralInt.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralInt.cs
index a5b4f758de3a1..a8e34d9deb2e4 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralInt.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralInt.cs
@@ -50,6 +50,7 @@ public ThingOptionalLiteralInt(int value)
         public bool Equals(ThingOptionalLiteralInt other) => Equals(_value, other._value);
 
         /// <inheritdoc/>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public override int GetHashCode() => _value.GetHashCode();
 
         /// <inheritdoc/>
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralString.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralString.cs
index 8e9adc2985334..720acc8b72f2d 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralString.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingOptionalLiteralString.cs
@@ -53,6 +53,7 @@ public ThingOptionalLiteralString(string value)
         public bool Equals(ThingOptionalLiteralString other) => string.Equals(_value, other._value, StringComparison.InvariantCultureIgnoreCase);
 
         /// <inheritdoc/>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public override int GetHashCode() => _value != null ? StringComparer.InvariantCultureIgnoreCase.GetHashCode(_value) : 0;
 
         /// <inheritdoc/>
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralFloat.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralFloat.cs
index 8fcd15d07dcaf..1c9e12da797bc 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralFloat.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralFloat.cs
@@ -50,6 +50,7 @@ public ThingRequiredLiteralFloat(float value)
         public bool Equals(ThingRequiredLiteralFloat other) => Equals(_value, other._value);
 
         /// <inheritdoc/>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public override int GetHashCode() => _value.GetHashCode();
 
         /// <inheritdoc/>
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralInt.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralInt.cs
index 8a781708c06ba..80b2d22ea5993 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralInt.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralInt.cs
@@ -50,6 +50,7 @@ public ThingRequiredLiteralInt(int value)
         public bool Equals(ThingRequiredLiteralInt other) => Equals(_value, other._value);
 
         /// <inheritdoc/>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public override int GetHashCode() => _value.GetHashCode();
 
         /// <inheritdoc/>
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralString.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralString.cs
index ba2c1ddfb8cbd..19e345029dda0 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralString.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ThingRequiredLiteralString.cs
@@ -53,6 +53,7 @@ public ThingRequiredLiteralString(string value)
         public bool Equals(ThingRequiredLiteralString other) => string.Equals(_value, other._value, StringComparison.InvariantCultureIgnoreCase);
 
         /// <inheritdoc/>
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public override int GetHashCode() => _value != null ? StringComparer.InvariantCultureIgnoreCase.GetHashCode(_value) : 0;
 
         /// <inheritdoc/>

From 439f4fb86b40769c28b2c32a4f7bb4e33264dbe8 Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Tue, 12 Nov 2024 09:43:13 +0800
Subject: [PATCH 2/5] update MGC version

---
 eng/Packages.Data.props | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eng/Packages.Data.props b/eng/Packages.Data.props
index 3bf8291725d35..905592aa38f2a 100644
--- a/eng/Packages.Data.props
+++ b/eng/Packages.Data.props
@@ -252,7 +252,7 @@
   </ItemGroup>
 
   <ItemGroup Condition="'$(IsGeneratorLibrary)' == 'true'">
-    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241110.3" />
+    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241111.4" />
   </ItemGroup>
 
   <!--

From 20168675cad1ec7f62f2a5e4172e7292a8f6a403 Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Tue, 12 Nov 2024 12:02:59 +0800
Subject: [PATCH 3/5] AzureOutputLibrary

---
 .../generator/Azure.Generator/src/AzureClientPlugin.cs          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureClientPlugin.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureClientPlugin.cs
index c24325be35538..73a3a83a2dba9 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureClientPlugin.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureClientPlugin.cs
@@ -26,7 +26,7 @@ public class AzureClientPlugin : ClientModelPlugin
 
     private AzureOutputLibrary? _azureOutputLibrary;
     /// <inheritdoc/>
-    public override OutputLibrary OutputLibrary => _azureOutputLibrary ??= new();
+    public override AzureOutputLibrary OutputLibrary => _azureOutputLibrary ??= new();
 
     /// <summary>
     /// The Azure client plugin to generate the Azure client SDK.

From 8183e2bdd866f3840d43c7cd3997625e82e02a38 Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Tue, 12 Nov 2024 13:43:13 +0800
Subject: [PATCH 4/5] Address comments

---
 .../Azure.Generator/src/AzureOutputLibrary.cs |  6 +---
 .../Abstraction/HttpPipelineProvider.cs       | 36 +++++++------------
 2 files changed, 14 insertions(+), 28 deletions(-)

diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs
index 99aff3ebb5c86..9b818bbed43ba 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs
@@ -11,10 +11,6 @@ namespace Azure.Generator
     public class AzureOutputLibrary : ScmOutputLibrary
     {
         /// <inheritdoc/>
-        protected override TypeProvider[] BuildTypeProviders()
-            => [
-                ..base.BuildTypeProviders(),
-                new RequestContextExtensionsDefinition(),
-            ];
+        protected override TypeProvider[] BuildTypeProviders() => [..base.BuildTypeProviders(), new RequestContextExtensionsDefinition()];
     }
 }
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
index b983bd9f3881f..af0ee39dacd1b 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
@@ -44,39 +44,29 @@ public override ValueExpression PerRetryPolicy(params ValueExpression[] argument
         public override ClientPipelineApi ToExpression() => this;
 
         public override MethodBodyStatement[] ProcessMessage(HttpMessageApi message, HttpRequestOptionsApi options)
-        {
-            var userCacellationToken = new ParameterProvider("userCancellationToken", $"", new CSharpType(typeof(CancellationToken)));
-            var statusOption = new ParameterProvider("statusOption", $"", new CSharpType(typeof(ErrorOptions)));
-            return new MethodBodyStatement[]
-            {
-                new VariableTupleExpression(false, userCacellationToken, statusOption).Assign(options.Invoke("Parse")).Terminate(),
-                Original.Invoke(nameof(HttpPipeline.Send), [message, userCacellationToken]).Terminate(),
-                MethodBodyStatement.EmptyLine,
-                new IfStatement(message.Response().IsError().And(new BinaryOperatorExpression("&", options.NullConditional().Property("ErrorOptions"), options.NoThrow()).NotEqual(options.NoThrow())))
-                {
-                    Throw(New.Instance(AzureClientPlugin.Instance.TypeFactory.ClientResponseApi.ClientResponseExceptionType, message.Response()))
-                },
-                MethodBodyStatement.EmptyLine,
-                Return(message.Response())
-            };
-        }
+            => BuildProcessMessage(message, options, false);
 
         public override MethodBodyStatement[] ProcessMessageAsync(HttpMessageApi message, HttpRequestOptionsApi options)
+            => BuildProcessMessage(message, options, true);
+
+        private MethodBodyStatement[] BuildProcessMessage(HttpMessageApi message, HttpRequestOptionsApi options, bool isAsync)
         {
-            var userCacellationToken = new ParameterProvider("userCancellationToken", $"", new CSharpType(typeof(CancellationToken)));
+            var userCancellationToken = new ParameterProvider("userCancellationToken", $"", new CSharpType(typeof(CancellationToken)));
             var statusOption = new ParameterProvider("statusOption", $"", new CSharpType(typeof(ErrorOptions)));
-            return new MethodBodyStatement[]
-            {
-                new VariableTupleExpression(false, userCacellationToken, statusOption).Assign(options.Invoke("Parse")).Terminate(),
-                Original.Invoke(nameof(HttpPipeline.SendAsync), [message, userCacellationToken], true).Terminate(),
+            return
+            [
+                new VariableTupleExpression(false, userCancellationToken, statusOption).Assign(options.Invoke("Parse")).Terminate(),
+                Original.Invoke(isAsync ? nameof(HttpPipeline.SendAsync) : nameof(HttpPipeline.Send), [message, userCancellationToken], isAsync).Terminate(),
                 MethodBodyStatement.EmptyLine,
                 new IfStatement(message.Response().IsError().And(new BinaryOperatorExpression("&", options.NullConditional().Property("ErrorOptions"), options.NoThrow()).NotEqual(options.NoThrow())))
                 {
-                    Throw(AzureClientPlugin.Instance.TypeFactory.ClientResponseApi.ToExpression().CreateAsync(message.Response()))
+                    isAsync
+                    ? Throw(AzureClientPlugin.Instance.TypeFactory.ClientResponseApi.ToExpression().CreateAsync(message.Response()))
+                    : Throw(New.Instance(AzureClientPlugin.Instance.TypeFactory.ClientResponseApi.ClientResponseExceptionType, message.Response()))
                 },
                 MethodBodyStatement.EmptyLine,
                 Return(message.Response())
-            };
+            ];
         }
     }
 }

From a716a87568a9ed1148756a6e60091585085ec431 Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Wed, 13 Nov 2024 09:06:31 +0800
Subject: [PATCH 5/5] format

---
 .../generator/Azure.Generator/src/AzureOutputLibrary.cs   | 2 +-
 .../src/Providers/RequestContextExtensionsDefinition.cs   | 8 +-------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs
index 9b818bbed43ba..2b539852e5c6d 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs
@@ -11,6 +11,6 @@ namespace Azure.Generator
     public class AzureOutputLibrary : ScmOutputLibrary
     {
         /// <inheritdoc/>
-        protected override TypeProvider[] BuildTypeProviders() => [..base.BuildTypeProviders(), new RequestContextExtensionsDefinition()];
+        protected override TypeProvider[] BuildTypeProviders() => [.. base.BuildTypeProviders(), new RequestContextExtensionsDefinition()];
     }
 }
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/RequestContextExtensionsDefinition.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/RequestContextExtensionsDefinition.cs
index 8f3994b00da6a..61c4dbace3304 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/RequestContextExtensionsDefinition.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/RequestContextExtensionsDefinition.cs
@@ -20,13 +20,7 @@ internal class RequestContextExtensionsDefinition : TypeProvider
 
         protected override string BuildRelativeFilePath() => Path.Combine("src", "Generated", "Internal", $"{Name}.cs");
 
-        protected override MethodProvider[] BuildMethods()
-        {
-            return
-            [
-                BuildParse()
-            ];
-        }
+        protected override MethodProvider[] BuildMethods() => [BuildParse()];
 
         private MethodProvider BuildParse()
         {