-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider replacing http-types crate with http crate #1644
Comments
For extra context, the @heaths Hope you don't mind the ping, I think this is somewhat important as the current state of affair raises clear red flags for anybody who reviews their dependency trees. |
I'd consider a PR, but there'll be a lot of changes coming up. We're planning to reduce dependencies as much as possible and practical and, IMO, pulling a crate just for a few simple types isn't worth the extra risk and build time. All that work is happening in a separate feature branch which we'll talk about in the not-so-distant future more. So whether you want to spend the time on a PR or not is up to you. As long as it isn't huge I'm happy to review, but it's not a high priority for me. That said, this code - these crates - will be community-maintained (including me, since this was always unofficial) for the foreseeable future so it may be good to remove a dead dependency as you suggest. |
Two years ago, I took us the other way. We were removing the cc @yoshuawuyts |
I appreciate that Rust, like JS, is a smattering of smaller crates comprising libraries; however, while we've always preferred first-party or even no dependencies, the "recent" events - not just I've looked through the other issue and PR you mentioned, but I don't understand in what scenarios compatibility with http-types is necessary (based on this comment). @cataggar care to elaborate? |
Gentle ping on this |
This is not currently a priority. The issue is left open as a tracking issue because I do want to get to this eventually, but we're trying to get our first betas out built on the new TypeSpec code emitter like all our other languages use (for their respective languages). I'd rather remove the dependency on From the OP,
All code in |
To summarize my read down the rabbit hole of comments e.g., #849 (comment), the gist is that we prefer |
Hey, I noticed you are using the unmaintained
http-types
crate for a little bit of codegen, plus itsStatusCode
andMethod
types. This is a tiny fraction of the functionality it includes, especially if you consider all of its dependencies.There is a much more minimal crate for HTTP types that is actively maintained and seems like it should fulfill all of your needs: https://crates.io/crates/http. Would you consider switching to it? It would of course be a breaking change. I might be able to post a PR if you're interested.
The text was updated successfully, but these errors were encountered: