Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Avocado] Support service group folder scenario #6201

Open
raych1 opened this issue May 18, 2023 · 3 comments
Open

[Avocado] Support service group folder scenario #6201

raych1 opened this issue May 18, 2023 · 3 comments
Assignees
@konrad-jamrozik
Labels
Central-EngSys This issue is owned by the Engineering System team. feature-request This issue requires a new behavior in the product in order be resolved. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. specs-model Issues requiring logic to be implemented by https://github.com/Azure/azure-sdk-tools/issues/8203

Comments

@raych1
Copy link
Member

raych1 commented May 18, 2023 •
edited
Loading

Avocado cannot identify the readme under service group folder. There're more and more services using service group folder structure and tooling should extend the support for this scenario.

Rule | Message
-- | --
❌ MISSING_README | Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.folder: Microsoft.Quantum/preview/2019-11-04-preview/examples
❌ MISSING_README | Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.folder: resource-manager/Microsoft.Quantum/preview/2019-11-04-preview
❌ MISSING_README | Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.folder: d04a75907d3e0afd2e12b27a579867d538656f9f/specification/quantum/resource-manager

<!--EndFragment-->
</body>
</html>Rule	Message
❌ [MISSING_README](https://github.com/Azure/avocado/blob/master/README.md#MISSING_README)	Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
folder: [Microsoft.Quantum/preview/2019-11-04-preview/examples](https://github.com/Azure/azure-rest-api-specs-pr/blob/d04a75907d3e0afd2e12b27a579867d538656f9f/specification/quantum/resource-manager/Microsoft.Quantum/preview/2019-11-04-preview/examples)
❌ [MISSING_README](https://github.com/Azure/avocado/blob/master/README.md#MISSING_README)	Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
folder: [resource-manager/Microsoft.Quantum/preview/2019-11-04-preview](https://github.com/Azure/azure-rest-api-specs-pr/blob/d04a75907d3e0afd2e12b27a579867d538656f9f/specification/quantum/resource-manager/Microsoft.Quantum/preview/2019-11-04-preview)
❌ [MISSING_README](https://github.com/Azure/avocado/blob/master/README.md#MISSING_README)	Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
folder: [d04a75907d3e0afd2e12b27a579867d538656f9f/specification/quantum/resource-manager](https://github.com/Azure/azure-rest-api-specs-pr/blob/d04a75907d3e0afd2e12b27a579867d538656f9f/specification/quantum/resource-manager)

This is an example PR.
https://github.com/Azure/azure-rest-api-specs-pr/pull/12613
//CC: @weshaggard @konrad-jamrozik
@raych1 raych1 added the Spec PR Tools Tooling that runs in azure-rest-api-specs repo. label May 18, 2023
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label May 18, 2023
@konrad-jamrozik konrad-jamrozik changed the title [Feature Request] Avocado support service group folder scenario [Avocado] support service group folder scenario May 18, 2023
@konrad-jamrozik konrad-jamrozik added the feature-request This issue requires a new behavior in the product in order be resolved. label May 18, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 May 23, 2023
@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools May 23, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Jun 5, 2023
@konrad-jamrozik
Copy link
Contributor

Relevant Teams discussion.

@konrad-jamrozik konrad-jamrozik mentioned this issue Aug 3, 2023
Merged
8 tasks
@konrad-jamrozik
Copy link
Contributor

Another relevant Teams discussion.

@konrad-jamrozik konrad-jamrozik changed the title [Avocado] support service group folder scenario [Avocado] Support service group folder scenario Aug 30, 2023
@konrad-jamrozik
Copy link
Contributor

This is relevant to:

@konrad-jamrozik konrad-jamrozik added the specs-model Issues requiring logic to be implemented by https://github.com/Azure/azure-sdk-tools/issues/8203 label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team. feature-request This issue requires a new behavior in the product in order be resolved. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. specs-model Issues requiring logic to be implemented by https://github.com/Azure/azure-sdk-tools/issues/8203
Projects
Azure SDK EngSys 🚢🎉
Status: 📋 Backlog
Spec PR Tools
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@konrad-jamrozik @raych1