Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DotNet-Automation] Package generation failure would set 'installInstructions' to null which cause automation failure #8561

Closed
raych1 opened this issue Jul 5, 2024 · 0 comments · Fixed by Azure/azure-sdk-for-net#44874
Assignees

Comments

@raych1
Copy link
Member

raych1 commented Jul 5, 2024

Description
For a spec PR containing the spec changes from multiple service folders, we need to generate them one by one and any failure of one package generation should not block other package generation. Currently, a package generation failure will set installInstructions to 'null' in the generateOutput.json, this will end the automation script execution.

Expected
installInstructions should not be set or set correctly, otherwise it would fail the schema validation.

Screenshot
image

Sample pipeline run
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3913620&view=logs&j=03afb3bb-7296-55ad-aa07-ceee610c73b2&t=0f320c29-1c90-5304-d2d3-c58a6bb76437

//CC: @chunyu3

@raych1 raych1 self-assigned this Jul 5, 2024
@raych1 raych1 changed the title [DotNet-Automation] One package generation failure would set 'installInstructions' to null which cause automation failure [DotNet-Automation] Package generation failure would set 'installInstructions' to null which cause automation failure Jul 5, 2024
@raych1 raych1 linked a pull request Jul 5, 2024 that will close this issue
@raych1 raych1 closed this as completed Jul 5, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in API to SDK automation Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant