Spelling: Remove deprecated --no-install, replace with --no #9013
Conversation
|
The following pipelines have been queued for testing: |
|
Chatted w/ @weshaggard, going to:
|
|
The following pipelines have been queued for testing: |
|
I refactored a bunch to get the tests into Pester. I'm curious to see if they pass in our pipelines as a lot of the code is coupled to both pipelines and error outputs (which can change when running in pipelines). |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
| @@ -0,0 +1,41 @@ | |||
| Describe 'Tool Version' { | |||
| BeforeAll { | |||
There was a problem hiding this comment.
@weshaggard -- This is done in lieu of adding a .vscode/cspell.json file to this repo's root.
| # This forces normal Write-Error behavior (as seen on desktop) for | ||
| # errors encountered during testing of | ||
| # check-spelling-in-changed-files.ps1. Setting this keeps errors out of | ||
| # the DevOps logs for successful tests. Any errors produced by these | ||
| # tests are expected or will result in test failures. | ||
| $OriginalTeamProjectId = $env:SYSTEM_TEAMPROJECTID | ||
| $env:SYSTEM_TEAMPROJECTID = $null |
There was a problem hiding this comment.
This is needed to prevent DevOps from showing a bunch of fake error messages produced by the testing.
| [string]$SourceCommittish = "${env:SYSTEM_PULLREQUEST_SOURCECOMMITID}", | ||
|
|
||
| [Parameter()] | ||
| [string]$TargetCommittish = ("origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH}" -replace "refs/heads/") |
There was a problem hiding this comment.
These are needed to push values through to Get-ChangedFiles during testing. It also makes it possible to run the tool and tests locally again.
|
@weshaggard -- Have a look. I made a few changes and added the tests into the |
|
The following pipelines have been queued for testing: |
Fixes #6315