Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch to sha256 from md5 to remedy CodeQL Warning #3356

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

kdestin
Copy link
Member

@kdestin kdestin commented Aug 20, 2024

Description

This pull request migrates from md5 to sha256

CodeQL warns against weak cryptography. This use of md5 doesn't seem to appear in a cryptographically sensitive context, but the easiest remediation for the CodeQL warnings is to switch to an approved hash function.

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team (mldocs@microsoft.com) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

    This use of md5 doesn't appear to be a cryptographically sensitive
    context, but the easiest remediation for the CodeQL flags is to
    switch to an approved hash function.
@kdestin kdestin enabled auto-merge (squash) August 20, 2024 17:18
@kdestin kdestin disabled auto-merge August 20, 2024 17:18
@kdestin kdestin enabled auto-merge (squash) August 20, 2024 17:18
@kdestin kdestin merged commit cb3b034 into main Aug 20, 2024
8 checks passed
@kdestin kdestin deleted the kdestin/codeql-md5-to-sha-256 branch August 20, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants