[AVM Module Issue]: resource-group omits managedBy which makes migrating to AVM impossible

[snelis]

Check for previous/existing GitHub issues

• I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/resources/resource-group

(Optional) Module Version

0.2.4 (latest)

Description

The module identifies that the managedBy propery is immutable, yet it does not make it configurable.

// managedBy: managedBy // removed due to immutable string, only used for managed resource groups

Since CARML used to set it to an empty string by default, you end up with the property:

"managedBy": "",

AVM then tries to deploy without this property and you get this error:

The managed by property of the resource group cannot be changed from its current value ''

Can we make this configurable so i can configure it to an empty string?

(Optional) Correlation Id

No response

[microsoft-github-policy-service]

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

[avm-team-linter]

@snelis, thanks for submitting this issue for the avm/res/resources/resource-group module!

Important

A member of the @Azure/avm-res-resources-resourcegroup-module-owners-bicep or @Azure/avm-res-resources-resourcegroup-module-contributors-bicep team will review it soon!

[segraef]

Hi @snelis thanks for bringing this up, have you thought about raising a PR for this?
Have a think about it, otherwise I'm happy to have a closer at it to get this solved to enable you to migrate to AVM.

[snelis]

Yes, but have not found time to look into this further, for now i stuck with CARML to avoid being blocked.

[microsoft-github-policy-service]

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

• To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
• To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

[segraef]

I'd like to understand your use case in a bit more detail. The reason we removed the managedBy parameter is because it's only used by managed resource groups. See correspondence Azure/ResourceModules#4351 (comment).

[microsoft-github-policy-service]

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

• To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
• To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

[microsoft-github-policy-service]

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

• To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
• Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

[snelis]

We come from the CARML, they transition into AVM.

The latest tag that was in use is 0.11.1 which is here
https://github.com/Azure/ResourceModules/blob/v0.11.1/modules/resources/resource-group/main.bicep

This tag deploys resource groups with the managedBy property.
It must be a string in that module, and default is ''

Therefore we now have resourcegroups with this property already in place (as an empty string).
So when i use the new AVM module that does not implement this property at all, i get this error from ARM.

The managed by property of the resource group cannot be changed from its current value ''

So this makes me unable to transition this module from CARML into AVM because they are incompatible with each other.

[snelis]

I also thought about a PR, but if you want this to be either a string, or omit the property we land in this issue:
Azure/bicep#387

[microsoft-github-policy-service]

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

• To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
• To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

[microsoft-github-policy-service]

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

• To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
• Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

[microsoft-github-policy-service]

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

• To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
• To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

[microsoft-github-policy-service]

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

• To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
• Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

[microsoft-github-policy-service]

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

• To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
• To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

[segraef]

@snelis, just fyi I have this on my backlog.

[segraef]

@snelis did you try using the resource group resource and setting the managedBy parameter?

[segraef]

Since the parameter was removed due to the decision of immutable string issues in CARML and before moving into AVM, we are not going to reintroduce the parameter again. We recommend using the generic resource group resource and setting the managedBy parameter or reference an existing resource group to enable you to transition to AVM.

[snelis]

It's immutable, so yes i can use the generic resource group to maintain it's current value, but i wont be able to transition into AVM.
I will have to keep using this generic resource group instead forever.
Not a big problem.