Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax bicepconfig.json validation for extensions, to allow file paths #14873

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Relax bicepconfig.json validation for extensions, to allow file paths #14873

merged 1 commit into from
Aug 23, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Aug 22, 2024 •
edited by microsoft-github-policy-service bot
Loading

Closes #14863

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 10532748626)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10532748626
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10532748626"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10532748626
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10532748626"

@github-actions GitHub Actions
Copy link
Contributor

Dotnet Test Results

    72 files   -     36      72 suites   - 36   24m 21s ⏱️ - 9m 10s
11 044 tests  -     20  11 044 ✅  -     19  0 💤 ±0  0 ❌  - 1 
25 864 runs   - 12 928  25 864 ✅  - 12 927  0 💤 ±0  0 ❌  - 1 

Results for commit 255b57d. ± Comparison against base commit 68f9bca.

@anthony-c-martin anthony-c-martin changed the title Fix for issue 14863 Relax bicepconfig.json validation for extensions, to allow file paths Aug 22, 2024
@anthony-c-martin anthony-c-martin merged commit 7c1ec1a into main Aug 23, 2024
47 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue14863 branch August 23, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenWeatherford StephenWeatherford StephenWeatherford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bicep local-deploy: false warnings in the bicepconfig.json when referencing a local path
2 participants
@anthony-c-martin @StephenWeatherford