Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker.sock mapping for linux agents #152

Open
plotzwi-eq opened this issue Jun 11, 2024 · 1 comment
Open

Add docker.sock mapping for linux agents #152

plotzwi-eq opened this issue Jun 11, 2024 · 1 comment
Assignees
Labels
question Requiring some clarification

Comments

@plotzwi-eq
Copy link

Currently it's not possible to fully utilize az acr commands, because the action is running inside container. Adding docker socket mapping could solve this.
For now for example I can't use az acr login command. I know I can use it with --expose-token, export it to variable and login with docker action, but it seems more like a workaround than an actual solution.

@plotzwi-eq plotzwi-eq added the need-to-triage Requires investigation label Jun 11, 2024
@MoChilia MoChilia added enhancement Feature request/improved experience question Requiring some clarification and removed need-to-triage Requires investigation enhancement Feature request/improved experience labels Jun 11, 2024
@MoChilia
Copy link
Member

Hi @plotzwi-eq, you're right, running az acr login in azure/cli is limited, because it requires calling the Docker CLI. But mapping the Docker socket inside a container is not recommended due to potential security risks (see https://jpetazzo.github.io/2015/09/03/do-not-use-docker-in-docker-for-ci/ for more information).

Instead, you can consider using the GitHub action for ACR login available at https://github.com/Azure/docker-login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Requiring some clarification
Projects
None yet
Development

No branches or pull requests

2 participants