Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go module ambiguous import errors #528

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Fix Go module ambiguous import errors #528

merged 2 commits into from
Jun 23, 2020

Commits on Jun 17, 2020

  1. Fix Go module ambiguous import errors

    This is an extension of the mitigations introduced in #455.
    Unfortunately, the original mitigations didn't address the primary cause
    of ambiguous import errors: the github.com/Azure/go-autorest module.
    
    The issue stems from the fact that old versions of the root module
    (github.com/Azure/go-autorest) provide the same packages as the newer
    submodules.
    
    To correct this situation, the _root module_ needs to be upgraded to a
    version that no longer provides those packages (a version where the
    submodules are present). Fortunately, the submodules can be leveraged to
    provide the necessary version bump.
    
    See: #414 (comment)
    
    ----
    
    Caveat: in order for this to work, an importable version of the root
    package needs to be referenceable.
    
    PR #527 makes the root package importable.
    
    The go.mod files assume that this importable version will be
    referenceable as v14.2.0. If the version where the importable package is
    available ends up being different, these files will need to be updated.
    
    See also: #395, #413, #414, #455, #481, #524
    miquella committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    62e1741 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Update go.sum files

    jhendrixMSFT committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    a67695f View commit details
    Browse the repository at this point in the history