Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile should support additional VM identities for AKS features/addons by populating NodeIdentities more thoroughly #355

Open
comtalyst opened this issue May 17, 2024 · 0 comments

Comments

@comtalyst
Copy link
Collaborator

Tell us about your request

Makefile should support additional VM identities for AKS features/addons by populating NodeIdentities more thoroughly

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

Nodes provisioned by Karpenter may not support some of the features/addons like the nodes provisioned by AKS.
This is due to the fact that the VM instance should contain necessary identities for those addons.

Karpenter already support populating those VM identities through NodeIdentities configuration option. But Makefile haven't utilize that yet.

Once it does, it probably needs to grab the identity IDs from managed cluster properties, then pass them into NodeIdentities.

Are you currently working around this issue?

No

Additional Context

This only applies to self-hosted Karpenter.
NAP should already support it.

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant