Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit tests for manualtoken.go #267

Closed
khareyash05 opened this issue Apr 30, 2023 · 3 comments · Fixed by #268
Closed

add unit tests for manualtoken.go #267

khareyash05 opened this issue Apr 30, 2023 · 3 comments · Fixed by #268

Comments

@khareyash05
Copy link
Contributor

I would like to add unit tests for pkg/token/manualtoken.go
@weinong
Copy link
Contributor

weinong commented May 1, 2023

go for it!

@khareyash05 khareyash05 mentioned this issue May 1, 2023
Merged
@khareyash05
Copy link
Contributor Author

@weinong Kindly review!

@khareyash05
Copy link
Contributor Author

@weinong Thank you for merging this PR. If there are more files which need unit testing, I am happy to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add unit tests for manualtoken_test.go khareyash05/kubelogin
2 participants
@weinong @khareyash05