Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonic-port.yang: add link training support #10025

Merged
merged 3 commits into from
May 15, 2022
Merged

sonic-port.yang: add link training support #10025

merged 3 commits into from
May 15, 2022

Conversation

ds952811
Copy link
Contributor

@ds952811 ds952811 commented Feb 18, 2022 •
edited
Loading

This is part of HLD sonic-net/SONiC#925

Why I did it

Add link-training support

How I did it

Update SONiC YANG for port link-training support

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Add "link_training" to sonic-port.yang

Link to config_db schema for YANG module changes

https://github.com/sonic-net/SONiC/wiki/Configuration#port

A picture of a cute animal (not mandatory but encouraged)

@ds952811 ds952811 requested a review from qiluo-msft as a code owner February 18, 2022 14:52
@ds952811 ds952811 mentioned this pull request Feb 18, 2022
Merged
@dgsudharsan dgsudharsan added the YANG YANG model related changes label Apr 1, 2022
dgsudharsan
dgsudharsan suggested changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@dgsudharsan dgsudharsan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add UT
Update schema in https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
Add sample configuration in https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/tests/files/sample_config_db.json

@ds952811 ds952811 force-pushed the link-training branch 2 times, most recently from eebf6be to 477c397 Compare April 18, 2022 04:00
dgsudharsan
dgsudharsan suggested changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@dgsudharsan dgsudharsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ds952811 I still see unit tests are missing in this PR. Apart from adding it in sample_config_db.json you should also add UT to cover negative test cases. Please refer to other yang PRs

@ds952811
Copy link
Contributor Author

@ds952811 I still see unit tests are missing in this PR. Apart from adding it in sample_config_db.json you should also add UT to cover negative test cases. Please refer to other yang PRs

Thanks, I think I know what's missing now, will update the PR

dgsudharsan
dgsudharsan previously approved these changes Apr 29, 2022
View reviewed changes
@ds952811
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 10025 in repo Azure/sonic-buildimage

@ds952811
Copy link
Contributor Author

ds952811 commented May 4, 2022

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ds952811
Copy link
Contributor Author

ds952811 commented May 5, 2022

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 10025 in repo Azure/sonic-buildimage

@ds952811
Copy link
Contributor Author

ds952811 commented May 5, 2022

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ds952811
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Pull request contains merge conflicts.

ds952811 added 3 commits May 10, 2022 00:31
@ds952811
sonic-port.yang: add link training support
c18cc99 
Signed-off-by: Dante Su <dante.su@broadcom.com>
@ds952811
add UT for link_training
2704c2f 
Signed-off-by: Dante Su <dante.su@broadcom.com>
@ds952811
add link_training tests to yang_model_tests
d1c6222 
Signed-off-by: Dante Su <dante.su@broadcom.com>
@ds952811 ds952811 dismissed stale reviews from dgsudharsan and Junchao-Mellanox via d1c6222 May 10, 2022 00:34
@ds952811
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft requested a review from ganglyu May 12, 2022 21:57
@qiluo-msft qiluo-msft merged commit 4b581f1 into sonic-net:master May 15, 2022
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
@yxieca
Merged PR 6148955: Manual merge internal branch with github master br…
a1e7352 
…anch

Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganglyu ganglyu ganglyu approved these changes

@Junchao-Mellanox Junchao-Mellanox Junchao-Mellanox approved these changes

@dgsudharsan dgsudharsan dgsudharsan left review comments

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

Assignees
No one assigned
Labels
YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ds952811 @mssonicbld @dgsudharsan @Junchao-Mellanox @ganglyu @qiluo-msft