[yang] In ACL_RULE PRIORITY is mandatory and also PACKET_ACTION for CTRLPLANE ACLs #10248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ghooo
changed the title
qiluo-msft
reviewed
Mar 18, 2022
| @@ -69,6 +69,9 @@ module sonic-acl { | |||
| type stypes:packet_action; | |||
| } | |||
|
|
|||
| /* Validating 'PACKET_ACTION' exist if ACL type is 'CTRLPLANE' */ | |||
There was a problem hiding this comment.
@bingwang-ms Is PACKET_ACTION mandatory for data plane ACL?
There was a problem hiding this comment.
No, PACKET_ACTION is not mandatory for data plane ACL.
For example, we can have below config for an ACL rule
# redis-cli -n 4 hgetall "ACL_RULE|EVERFLOW|RULE_3"
1) "PRIORITY"
2) "9997"
3) "MIRROR_INGRESS_ACTION"
4) "session_1"
5) "L4_SRC_PORT"
6) "4661"
qiluo-msft
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixes sonic-net/sonic-utilities#2049
from caclmgr:
I think PRIORITY is a required field for ACLs not only CTRLPLANE ACLs
How I did it
Check code.
How to verify it
Unit-test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)