Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DHCP relay] Enlarge alias size to be equal to the definition of linu… #10689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

irene-pan1202
Copy link

Why I did it

The maximum alias size defined by isc-dhcp is 16, if the alias length exceeds 16, which will cause the Circuit-ID of option82 error.

How I did it

Enlarge alias size to be equal to the definition of linux source.

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

…x source

The maximum alias size defined by isc-dhcp is 16, if the alias length exceeds 16, which will cause the Circuit-ID of option82 error.

Signed-off-by: irene_pan <irene_pan@edge-core.com>
@irene-pan1202 irene-pan1202 requested a review from lguohan as a code owner April 26, 2022 09:23
In isc-dhcp design, need to set the client vlan interface ip as giaddr so the server can figure out what net it's from and so that we can later forward the response to the correct net.

Signed-off-by: irene_pan <irene_pan@edge-core.com>
@irene-pan1202 irene-pan1202 requested review from a team as code owners June 10, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant