[Accton] Fix wrong system eeprom data of 0x25 field #10784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timestamp will be discarded by eeprom.__parse_output()
Corrected data:
Manufacture Date 0x25 19 06/22/2018 17:23:18
Wrong data:
Manufacture Date 0x25 19 06/22/2018
Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
brandonchuang
requested review from
sujinmkang,
prgeor and
vdahiya12
as code owners
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brandon Chuang brandon_chuang@edge-core.com
Why I did it
The TLV info get from platform_chassis.get_system_eeprom_info() is not correct.
The timestamp will be discarded by eeprom.__parse_output()
Corrected data:
Manufacture Date 0x25 19 06/22/2018 17:23:18
Wrong data:
Manufacture Date 0x25 19 06/22/2018
How I did it
Modify eeprom.__parse_output()
How to verify it
Invoke chassis.get_system_eeprom_info() to verify the "Manufacture Date"
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)