[Celestica] Fix Seastone2 LED init script to not break port status #10827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasstockner
requested review from
sujinmkang,
prgeor and
vdahiya12
as code owners
lukasstockner
force-pushed
the
seastone-2-port-status-led-fix
branch
from
736a524 to
55b15c3
Compare
Fixes sonic-net#10103. The LED init script that was added in sonic-net#9769 enables the port LEDs, but it turns out that the linkscan change combined with Broadcom SAI 6.0 breaks detection of port status on boot. Without the linkscan and sleep, the LED still work as expected, and the port status is correct again. Signed-off-by: Lukas Stockner <lstockner@genesiscloud.com>
lukasstockner
force-pushed
the
seastone-2-port-status-led-fix
branch
from
55b15c3 to
d67e5ee
Compare
grische
approved these changes
Dec 11, 2023
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Feb 3, 2024
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Feb 19, 2024
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Feb 19, 2024
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Mar 3, 2024
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixes #10103.
The LED init script that was added in #9769 enables the port LEDs, but it turns out that the linkscan change combined with Broadcom SAI 6.0 breaks detection of port status on boot.
How I did it
Without the linkscan and sleep, the LEDs still work as expected, and the port status is correct again.
Fixed script was provided by @jonwhaley: #10103 (comment)
How to verify it
Apply the change on a Seastone2 switch, reboot, observe that port LEDs work and link status is detected.
Which release branch to backport (provide reason below if selected)
#9769 is only included in 202111.
Description for the changelog
Fix Seastone2 port status detection on boot.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)