-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[memory_checker] Retrieves high memory alert status and memory threshold from CONFIG_DB
#11312
Open
yozhao101
wants to merge
16
commits into
sonic-net:master
Choose a base branch
from
yozhao101:retrieve_memory_alerting_from_DB
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[memory_checker] Retrieves high memory alert status and memory threshold from CONFIG_DB
#11312
yozhao101
wants to merge
16
commits into
sonic-net:master
from
yozhao101:retrieve_memory_alerting_from_DB
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of each container from `CONFIG_DB`. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
add syslog statement in `memory_checker`. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
…mory_alerting_from_DB Signed-off-by: Yong Zhao <yozhao@microsoft.com>
…onfig file. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yong Zhao yozhao@microsoft.com
Why I did it
This PR aims to propose a feature of high memory alerting on containers in SONiC. The design is: sonic-net/SONiC#1016. PR to implement the CLI is: sonic-net/sonic-utilities#2243.
How I did it
I added a Monit configuration file for each container. Meanwhile,
memory_checker
will read high memory alerting status and memory threshold of each container fromCONFIG_DB
. The memory threshold of each container will be initialized ininit_cfg.json.j2
file.How to verify it
I verfied this change on a lab device and will also have sonic-mgmt test cases to do fully testing of this mechanism.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)