Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Celestica Redstone XP D2060 #11426

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DACRepair
Copy link

@DACRepair DACRepair commented Jul 12, 2022

Why I did it

There have been requests for something to run on this switch by the homelab community. I ordered one myself before realizing that there was practically no support. After many sleepless nights, and learning how interesting the platform was I decided to give it a whirl.

How I did it

The Celestica DX010 and Redstone XP use the same base platform. Much of the documentation can be found within the DX010 code, as well as through debugging with Cumulus and ONL.

How to verify it

The platform uses the Broadcom implementation of SONiC. Building the image using PLATFORM=broadcom will produce a usable image on this platform.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Added support for the Celestica Redstone XP D2060

Link to config_db schema for YANG module changes

This does not include any additional YANG changes.

A picture of a cute animal (not mandatory but encouraged)

Here's my pupper:
image

@ghost
Copy link

ghost commented Jul 12, 2022

CLA assistant check
All CLA requirements met.

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2022

This pull request introduces 8 alerts when merging 82afe468ddb0bde84cb384cb0a9bf3885629b012 into 503a0f7 - view on LGTM.com

new alerts:

  • 3 for Except block handles 'BaseException'
  • 3 for 'import *' may pollute namespace
  • 1 for Unused import
  • 1 for Wrong name for an argument in a class instantiation

device/celestica/x86_64-cel_redstone_xp-r0: Added device configuration and sonic_platform.

* Added sonic device configurations.
* Added SAI configuration.
* Added LED code.
* Added "legacy" plugins until they are deprecated.
* Added sonic_platform.

platform/broadcom: Added entries to package build list.
platform/broadcom/sonic-platform-cel: Added gitignore to add debian folder.
platform/broadcom/sonic-platform-cel/debian: Added debian package configuration and init/install scripts.
platform/broadcom/sonic-platform-cel/redstonexp: Added platform drivers.

* Added platform drivers.
* Added platform config.

Signed-off-by: Derek Vance DACepair@gmail.com
@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2022

This pull request introduces 8 alerts when merging d551fc9 into 429254c - view on LGTM.com

new alerts:

  • 3 for Except block handles 'BaseException'
  • 3 for 'import *' may pollute namespace
  • 1 for Unused import
  • 1 for Wrong name for an argument in a class instantiation

device/celestrica/x86_64-cel_redstone_xp-r0/sonic_platform/helper.py: `BaseException` instances handled.
device/celestrica/x86_64-cel_redstone_xp-r0/sonic_platform/psu.py: Changed `Fan` class to use extended one.
device/celestrica/x86_64-cel_redstone_xp-r0/sonic_platform/thermal_manager.py: Fixed polluting imports.
platform/broadcom/sonic-platform-cel/redstonexp/setup.py: Removed `import os`.
@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2022

This pull request introduces 1 alert when merging f9af481 into 429254c - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a class instantiation

…nged use of the `Fan` class for the PSU fans.

device\celestica\x86_64-cel_redstone_xp-r0\sonic_platform\fan.py: Changed the logic to calculate if the fan is part of a PSU.
@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2022

This pull request introduces 1 alert when merging 83bf8ce into bec35df - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a class instantiation

@DACRepair DACRepair marked this pull request as ready for review July 14, 2022 05:32
@DACRepair DACRepair requested review from a team and lguohan as code owners July 14, 2022 05:32
@Sch-LikA
Copy link

Sch-LikA commented Sep 7, 2023

I'd love seeing the Redstone XP supported by SONiC, why is this PR stuck ?

@lguohan lguohan added the device label Sep 23, 2023
@Customs8384
Copy link

How could we get this to work? If someone redeveloped this against current master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants