[YANG] Add constraint for loopback interface name formatting #11483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Jul 19, 2022
| leaf name { | ||
| type string { | ||
| length 1..128; | ||
| pattern 'Loopback[0-9]{1,3}'; |
There was a problem hiding this comment.
Please add unit test cases for valid/invalid usage?
There was a problem hiding this comment.
Please add the related checking code into PR description.
ganglyu
reviewed
Jul 20, 2022
| type string; | ||
| leaf name { | ||
| type string { | ||
| length 1..128; |
There was a problem hiding this comment.
you have defined pattern, is length still necessary?
|
buildimage pipeline failed, please build target or run unit test before commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Loopback interface YANG model was missing the constraint for Loopback interface name formatting (should be LoopbackXXX)
How I did it
Add constraint to YANG model
How to verify it
Try configuring Loopback interface name to valid and invalid names
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)