[minigraph][dualtor] add DualToR type in DEVICE_METADATA #11689
Conversation
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
please provide some details in the description as required by the template. It will be useful for referencing the new attribute and how it looks like with the change |
| @@ -151,6 +151,12 @@ module sonic-device_metadata { | |||
| } | |||
| } | |||
|
|
|||
| leaf DualToRtype { | |||
| @@ -151,6 +151,12 @@ module sonic-device_metadata { | |||
| } | |||
| } | |||
|
|
|||
| leaf DualToRtype { | |||
| type string { | |||
| pattern "active-active|active-standby"; | |||
| @@ -151,6 +151,12 @@ module sonic-device_metadata { | |||
| } | |||
| } | |||
|
|
|||
| leaf DualToRtype { | |||
There was a problem hiding this comment.
If it's not dual tor device, what's the expected value? active-active?
There was a problem hiding this comment.
dualtortype is expected to be only active-active or active-standby
|
Please update sample_config_db.json |
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@vdahiya12 can you please help to address this comments? Thanks. |
|
@vdahiya12 can you please help to take a look at this issue? Thanks. |
|
lower priority right now |
|
@ganglyu Why this could pass load_minigraph UT if this one is not merged? |
|
@vdahiya12 Please prioritize the UT, and make PR ready for review. |
In load_minigraph UT, we run yang validation for generated config_db. |
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
Why I did it
This PR adds a DualToRType field to DEVICE_METADATA table in config DB.
the subtypes can be
active-activeoractive-standbyUsing this field we can distinguish between
active-activeoractive-standbytopology.How I did it
Changed the minigraph parser for including the DualToRType field in DEVICE_METADATA
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)