Fix syncd autorestart sequence #12460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Kolomeiets <oleksandrx.kolomeiets@intel.com>
msosyak
approved these changes
Oct 20, 2022
|
@lguohan, please review the changes. |
|
@lguohan, |
|
@stepanblyschak, @lguohan, |
|
@prsunny , can you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
On startup Swss service flushes Redis DB, starts Swss container and Syncd service.
Then the service waits until either Swss or Syncd container stops.
During teardown it stops Swss container (if any) and Syncd service.
In case autorestart is enabled, when Syncd process is killed (for example, with
docker exec -it syncd pkill syncd) the following sequence of events happens:Event 3 should not happen.
How I did it
Increased the time to sleep before restarting Syncd service to 30 seconds, following example of next services:
How to verify it
Stop Syncd process with
docker exec -it syncd pkill syncd.Observe containers's statuses with
watch docker ps -a.Ensure Syncd container restarts only once.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Fix syncd autorestart sequence.
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)