Add ZR module support and apply new buffer setting for Wistron 3200K #12697
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if not commands: | ||
| try: | ||
| starter_command, *commands = starter_command.split('|') | ||
| except AttributeError: |
Check notice
Code scanning / CodeQL
Empty except
There was a problem hiding this comment.
@RogerX87 can you check this code scan
There was a problem hiding this comment.
For this try-exception case, it just handle the "commands" not exist but which is not our case. We have sub-commands in our case.
So we just keep it pass.
We only have one case which separate original command to 3 sub-commands. This check case is handle the command with "|" like "ipmitool mc info | grep 'Firmware Revision' | awk '{printf $4}'".
| @@ -70,7 +70,7 @@ | |||
| for file in dirs: | |||
| if file.startswith("hwmon"): | |||
| return file | |||
| except BaseException: | |||
| except IOError: | |||
Check notice
Code scanning / CodeQL
Empty except
| else: | ||
| return None | ||
|
|
||
| def write_eeprom(self, offset, num_bytes, write_buffer): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns
|
This pull request fixes 1 alert when merging 0e93a5f into 66b6c21 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging ef5a8a1 into 66b6c21 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
@lguohan , please help review, thanks. |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 12697 in repo sonic-net/sonic-buildimage |
|
@lguohan shall we get this PR merged? thanks. |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Why I did it
To support ZR modules setting and apply new buffer setting
How I did it
Apply the code
How to verify it
call the python api and check the value in transceiver eeprom
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)