add redis repo re #13478 #13479
Open
add redis repo re #13478 #13479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding the redis repo to the docker-database image remove sudo add gpupg for apt redis repo key add gpupg for apt redis repo key Update Dockerfile.j2
ITJamie
force-pushed
the
redis-server-repo
branch
from
226110f to
d1e83a2
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 13479 in repo sonic-net/sonic-buildimage |
|
@ITJamie I am not sure how much of performance penalty will be there if we enable Active defragmentation? |
|
@ITJamie did you investigate why redis DB is using so much memory in your case? 4.75GB (without accounting fragmentation) of REDIS DB memory usage seems too high... |
|
@ITJamie currently, Debian Redis use jemalloc for all archs including arm. I remember that the official Redis use libc as mem allocator for arm platform, and we observed issue where the memory will not be reclaimed on time when use libc. Can you help confirm what is the compile option of official Redis binary for arm platform? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
resolves #13478
Adding the redis repo to the docker-database image, this allows usage of redis memory defrag feature
How I did it
Added repo config to database docker template
How to verify it
build and verify that redis works as expected
Which release branch to backport (provide reason below if selected)
Description for the changelog
move to using redis official builds instead of debian builds
A picture of a cute animal (not mandatory but encouraged)