frrcfgd: fix incorrect rendering of route-map references #14183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A reference to a route-maps under a BGP address family is a single-value string, not a multi-value list. Looping over it yields incorrect configuration being rendered, for example: ``` neighbor peergroup route-map R in neighbor peergroup route-map M in neighbor peergroup route-map A in neighbor peergroup route-map P in ``` These overwrite each other as the configuration is loaded, making the effective FRR contain only the last one listed. This route-map (in this case called `P`) does most likely not exist, leading to an effective configuration which rejects all routes. The correct and expected rendered configuration would be: ``` neighbor peergroup route-map RMAP in ``` Signed-off-by: Tore Anderson <tore@redpill-linpro.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
frrcfgdgenerated incorrect configuration that referred to route-maps under BGP address families, e.g.:This happens because the Jinja2 templates looped over the string, leading to a new line for each individual character in the route-map name.
How I did it
Removed the
forloops so that only a single line is being rendered.How to verify it
Expected output from the last two commands:
Which release branch to backport (provide reason below if selected)
Reason: current templates will load incorrect and quite possibly harmful configuration after the BGP container restarts.
Description for the changelog
frrcfgd: fix incorrect rendering of route-map references
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)