Reduce size of docker containers #14214
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the apt package lists (`/var/lib/apt/lists`) from the docker containers. This saves about 100MB. Also, make a macro to clean up the apt and python cache that can then be used in all of the containers. This helps make the cleanup be consistent across all containers. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
libswsscommon-dev is a dev package, and shouldn't be needed at runtime. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
BTW you can find the same cleanup code in src/sonic-build-hooks/scripts/post_run_cleanup. |
|
Ah, I was comparing the size of the containers in 202205 (where the PR that added that script is not present) and the current master branch, so that would explain it. I'll modify this PR, since there's some additional changes to be done for some space savings. |
|
For master branch it's something like this:
Some time ago I wanted to remove 1st cleanup but this leads to modifying version files. So I decided don't change this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
Remove apt package lists, unify container layer cleanup code, remove unnecessary -dev packages from the sonic-telemetry container
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)