add minpoll&maxpoll for NTP server in sonic-ntp.yang

[bsun-sudo]

Why I did it

Add minpoll and maxpoll for NTP server in sonic-ntp.yang
PR for NTP HLD update is sonic-net/SONiC#1478

How I did it

Add minpoll and maxpoll for NTP server in sonic-ntp.yang. Added additional test cases in ntp.json and sample_config_db.json

How to verify it

Successfully built
sonic_yang_mgmt-1.0-py3-none-any.whl
sonic_yang_models-1.0-py3-none-any.whl

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: bsun-sudo (a54c435, 16321fd, 7cfa9c9, edafc91)

[ganglyu]

@wen587
Would you please check the GCU error?

[wen587]

Hi, the issue looks the same as YANG backlink issue.
The different part is that we can temp fix the previous backlink issue by commnet out sonic-yang include. This one is not caused by sonic-vlan include.

It is missing VLAN_MEMBER link after the YANG modification.

def test_find_ref_paths__path_is_table__returns_ref_paths(self):
# Arrange
path = "/PORT"
expected = [
"/ACL_TABLE/DATAACL/ports/0",
"/ACL_TABLE/EVERFLOW/ports/0",
"/ACL_TABLE/EVERFLOWV6/ports/0",
"/ACL_TABLE/EVERFLOWV6/ports/1",
"/ACL_TABLE/NO-NSW-PACL-V4/ports/0",
"/VLAN_MEMBER/Vlan1000|Ethernet0",
"/VLAN_MEMBER/Vlan1000|Ethernet4",
"/VLAN_MEMBER/Vlan1000|Ethernet8"
]

E First list contains 3 additional elements.
E First extra element 5:
E '/VLAN_MEMBER/Vlan1000|Ethernet0'
E
E ['/ACL_TABLE/DATAACL/ports/0',
E '/ACL_TABLE/EVERFLOW/ports/0',
E '/ACL_TABLE/EVERFLOWV6/ports/0',
E '/ACL_TABLE/EVERFLOWV6/ports/1',
E + '/ACL_TABLE/NO-NSW-PACL-V4/ports/0']

[wen587]

It seems caused by another PR which involve the vlan import. I created revert PR for this issue: #16322

[saiarcot895]

What's the difference between this test case and the one above?

[saiarcot895]

Ah, never mind, I see that since the default minpoll is 6, this returns an error.

[zhangyanzhao]

@bsun-sudo can you please help to fix the build failure? Thanks.