Include voltage and current sensors in system health. #16646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Added voltage and current sensors in system health determination. Enhancement as part of HLD - sonic-net/SONiC#1394
Work item tracking
How I did it
Added checks for sensors in hardware_checker script
How to verify it
show system-health detail, will show all voltage/current sensors and their status.
Check UT log.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
Unit test
root@sonic:/home/cisco# show system-health det
System status summary
System status LED green
Services:
Status: OK
Hardware:
Status: Not OK
Reasons: Voltage sensor VP0P85_VDD_PHY1217 measurement 0 mV out of range (709,902)
...
VP0P85_VDD_PHY1217 Not OK voltage
VP1P7_CPU_C OK voltage
VP1P3_CPU_C OK voltage
...
A picture of a cute animal (not mandatory but encouraged)