Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete stretch and jessie references #17075

Closed
wants to merge 2 commits into from

Conversation

bluecmd
Copy link
Contributor

@bluecmd bluecmd commented Nov 2, 2023

Remove the end-of-life'd Debian distributions. Replace all legacy references with bullseye to push the bar to modern distributions.

Why I did it

Pay some technical debt by cleaning up old references that should not be used for future releases.

How I did it

Mostly git grep and similar for jessie and stretch.

How to verify it

If it builds, it works.

Which release branch to backport (provide reason below if selected)

None, this is only for new releases.

Tested branch (Please provide the tested image version)

N/A

Description for the changelog

For releases 2024 and later the use of Jessie and Stretch are no longer supported.

Link to config_db schema for YANG module changes

N/A

A picture of a cute animal (not mandatory but encouraged)

image

@bluecmd bluecmd force-pushed the pr-remove-old-debians branch from 3bbe93a to 423c117 Compare November 2, 2023 14:57
@bluecmd bluecmd changed the title WIP: Delete stretch and jessie references Delete stretch and jessie references Nov 2, 2023
@lguohan lguohan requested a review from saiarcot895 November 2, 2023 23:32
@bluecmd bluecmd requested a review from saiarcot895 November 3, 2023 10:02
Remove the end-of-life'd Debian distributions. Replace all legacy
references with bullseye to push the bar to modern distributions.

Signed-off-by: Christian Svensson <blue@cmd.nu>
 - Change base of docker-sonic-p4 to bullseye base
 - Remove fallback case not needed for dists later than Jessie

Signed-off-by: Christian Svensson <blue@cmd.nu>
@bluecmd bluecmd force-pushed the pr-remove-old-debians branch from 78339a9 to b236f50 Compare November 3, 2023 11:17
@bluecmd
Copy link
Contributor Author

bluecmd commented Nov 6, 2023

@saiarcot895 @lguohan Any more feedback? Or do you think this can be merged?

@bluecmd
Copy link
Contributor Author

bluecmd commented Nov 10, 2023

Ping @lguohan! Any chance to merge this? Not sure what the ms_conflict is about.

@saiarcot895
Copy link
Contributor

@bluecmd Can you update your PR for the current code? Changes for Bookworm got merged in recently.

@bluecmd
Copy link
Contributor Author

bluecmd commented Nov 29, 2023

@bluecmd Can you update your PR for the current code? Changes for Bookworm got merged in recently.

Since there was 4 weeks of no comments after several pings - I'm not interested in doing that without a promise that this PR will be merged. I would hate to put in a new weekends worth of work to test it all and not have the PR merged and no communicated reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants