Don't restart ntpsec if the mgmt address gets a DHCP response #17296
Conversation
For setups where the mgmt interface address is assigned by a DHCP server, don't restart ntpsec in those cases with any NTP information received by the DHCP server. For SONiC, NTP configuration is (currently) separate from any information received from DHCP. In addition, if this happens at bootup time, there's a chance of a deadlock within systemctl happening. Fixes sonic-net#17114. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
@fastiuk Should the NTP server information given in DHCP server responses be applied to the NTP server on the DUT? I was under the assumption that the NTP configuration should be separate from DHCP, but I see the HLD for NTP configuration mentions DHCP support/handling. |
Under this PR we add support for controlling NTP dhcp configuration. So if NTP dhcp state is enabled - we need to use the config provided by DHCP server. But if disabled, we don't need to do so |
|
@saiarcot895 Any update on this? |
|
@saiarcot895 Can you please provide ETA for merging this PR? |
Fixes #17114.
Why I did it
For setups where the mgmt interface address is assigned by a DHCP server, don't restart ntpsec in those cases with any NTP information received by the DHCP server. For SONiC, NTP configuration is (currently) separate from any information received from DHCP. In addition, if this happens at bootup time, there's a chance of a deadlock within systemctl happening.
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)